Fix: Raise Error When UpdateReplacePolicy is not correctly defined. (#3392)

Author: Connor Robertson

samtranslator/plugins/api/implicit_api_plugin.py

@@ -496,8 +496,8 @@ def _update_resource_attributes_from_api_event(  # noqa: PLR0913
         method_conditions = api_dict_condition.setdefault(path, {})
         method_conditions[method] = condition
 
-        api_dict_deletion = self.api_deletion_policies.setdefault(api_id, set())
-        api_dict_deletion.add(deletion_policy)
+        api_dict_deletion = self.api_deletion_policies.setdefault(api_id, [])
+        api_dict_deletion.append(deletion_policy)
 
-        api_dict_update_replace = self.api_update_replace_policies.setdefault(api_id, set())
-        api_dict_update_replace.add(update_replace_policy)
+        api_dict_update_replace = self.api_update_replace_policies.setdefault(api_id, [])
+        api_dict_update_replace.append(update_replace_policy)

tests/translator/input/valid_update_replace_policy_and_deletion_policy.yaml

@@ -0,0 +1,59 @@
+AWSTemplateFormatVersion: '2010-09-09'
+Transform:
+- AWS::LanguageExtensions
+- AWS::Serverless-2016-10-31
+
+Resources:
+  MyFunction:
+    Type: AWS::Serverless::Function
+    UpdateReplacePolicy: Delete
+    Properties:
+      Handler: LambdaASP.NETCoreWebAPI2::LambdaASP.NETCoreWebAPI2.LambdaEntryPoint::FunctionHandlerAsync
+      Runtime: dotnet6
+      CodeUri: s3://bucket/key
+      Events:
+        None:
+          Type: Api
+          Properties:
+            Method: get
+            Path: /method
+  MyFunction2:
+    Type: AWS::Serverless::Function
+    UpdateReplacePolicy: Delete
+    Properties:
+      Handler: LambdaASP.NETCoreWebAPI2::LambdaASP.NETCoreWebAPI2.LambdaEntryPoint::FunctionHandlerAsync
+      Runtime: dotnet6
+      CodeUri: s3://bucket/key
+      Events:
+        Hi:
+          Type: Api
+          Properties:
+            Method: post
+            Path: /method
+  MyFunction3:
+    Type: AWS::Serverless::Function
+    DeletionPolicy: Delete
+    Properties:
+      Handler: LambdaASP.NETCoreWebAPI2::LambdaASP.NETCoreWebAPI2.LambdaEntryPoint::FunctionHandlerAsync
+      Runtime: dotnet6
+      CodeUri: s3://bucket/key
+      Events:
+        All:
+          Type: Api
+          Properties:
+            Method: get
+            Path: /method2
+  MyFunction4:
+    Type: AWS::Serverless::Function
+    DeletionPolicy: Retain
+    UpdateReplacePolicy: Retain
+    Properties:
+      Handler: LambdaASP.NETCoreWebAPI2::LambdaASP.NETCoreWebAPI2.LambdaEntryPoint::FunctionHandlerAsync
+      Runtime: dotnet6
+      CodeUri: s3://bucket/key
+      Events:
+        Bye:
+          Type: Api
+          Properties:
+            Method: post
+            Path: /method2