add integration test for LMI functions #3863
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnusunny
previously approved these changes
Dec 17, 2025
valerena
reviewed
Dec 17, 2025
integration/combination/test_function_with_capacity_provider.py
Outdated
Show resolved
Hide resolved
integration/resources/templates/combination/function_lmi_custom.yaml
Outdated
Show resolved
Hide resolved
integration/resources/templates/combination/function_lmi_custom.yaml
Outdated
Show resolved
Hide resolved
integration/resources/templates/combination/function_lmi_default.yaml
Outdated
Show resolved
Hide resolved
bnusunny
previously approved these changes
Jan 7, 2026
valerena
reviewed
Jan 13, 2026
integration/combination/test_function_with_capacity_provider.py
Outdated
Show resolved
Hide resolved
integration/combination/test_function_with_capacity_provider.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Run integration tests: |
bnusunny
approved these changes
Jan 14, 2026
valerena
reviewed
Jan 16, 2026
Comment on lines
+108
to
+113
| simple_capacity_provider = next( | ||
| r for r in capacity_provider_resources if r["LogicalResourceId"] == "SimpleCapacityProvider" | ||
| ) | ||
| advanced_capacity_provider = next( | ||
| r for r in capacity_provider_resources if r["LogicalResourceId"] == "AdvancedCapacityProvider" | ||
| ) |
Contributor
There was a problem hiding this comment.
You can use the same self.get_physical_id_by_logical_id in these two, right? (changing inside get_lambda_capacity_provider_config to just use the parameter instead of having to take the physical id from it)
Comment on lines
+128
to
+151
| # Phase 5: Validate SimpleCapacityProvider configuration | ||
| simple_cp_config = self.get_lambda_capacity_provider_config(simple_capacity_provider) | ||
| self.assertIsNotNone(simple_cp_config, "SimpleCapacityProvider should have configuration") | ||
| self.assertEqual(simple_cp_config["State"], "Active", "SimpleCapacityProvider should be in Active state") | ||
|
|
||
| # Verify the function uses SimpleCapacityProvider | ||
| simple_cp_arn = simple_cp_config.get("CapacityProviderArn") | ||
| self.assertEqual( | ||
| function_capacity_provider_arn, simple_cp_arn, "Function should reference SimpleCapacityProvider ARN" | ||
| ) | ||
|
|
||
| # Verify SimpleCapacityProvider VPC configuration | ||
| simple_vpc_config = simple_cp_config.get("VpcConfig") | ||
| self.assertIsNotNone(simple_vpc_config, "SimpleCapacityProvider should have VPC configuration") | ||
| self.assertIn( | ||
| self.companion_stack_outputs["LMISubnetId"], | ||
| simple_vpc_config["SubnetIds"], | ||
| "SimpleCapacityProvider should use the correct subnet", | ||
| ) | ||
| self.assertIn( | ||
| self.companion_stack_outputs["LMISecurityGroupId"], | ||
| simple_vpc_config["SecurityGroupIds"], | ||
| "SimpleCapacityProvider should use the correct security group", | ||
| ) |
Contributor
There was a problem hiding this comment.
It looks like all these basic checks are being repeated for the advanced capacity provider. Can we take them out to a separate function so can just reuse the same checks in both places instead of duplicating the code? (and it can be used in the previous tests too)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Add integration test for deploying application with CapacityProvider and LMI functions
Description of changes
Add test data and test cases for successfully deployment of resources.
Description of how you validated changes
Checklist
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.