Skip to content

Commit 19ce263

Browse files
authored
Merge pull request #3 from mattcorey/revert-2-profile-support
Revert "Profile support"
2 parents 7205220 + 054c2b0 commit 19ce263

File tree

12 files changed

+7
-168
lines changed

12 files changed

+7
-168
lines changed

README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class LambdaHandler implements RequestHandler<AwsProxyRequest, AwsProxyRe
3636
```
3737

3838
### Spring support
39-
The library supports Spring applications that are configured using annotations (in code) rather than in an XML file. The simplest possible configuration uses the `@ComponentScan` annotation to load all controller classes from a package. For example, our unit test application has the following configuration class.
39+
The library supports Spring applications that are configured using annotations (in code) rather than in an XML file. The simplest possible configuration uses the `@ComponentScan` annotation to load all controller classes from a package. For example, our unit test application has the following configuuration class.
4040

4141
```java
4242
@Configuration
@@ -57,9 +57,6 @@ public class LambdaHandler implements RequestHandler<AwsProxyRequest, AwsProxyRe
5757
}
5858
```
5959

60-
#### Spring Profiles
61-
You can enable Spring Profiles (as defined with the `@Profile` annotation) by deploying your Lambda under a stage name that matches the profile name. This will allow you to create a single package with support for different resources for dev, test, prod, etc. See [@Profile documentation](http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/context/annotation/Profile.html) for details.
62-
6360
### Spark support
6461
The library also supports applications written with the [Spark framework](http://sparkjava.com/). When using the library with Spark, it's important to initialize the `SparkLambdaContainerHandler` before defining routes.
6562

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsProxyServletContext.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -410,9 +410,6 @@ public String getVirtualServerName() {
410410
return null;
411411
}
412412

413-
public String getStage() {
414-
return awsProxyRequest.getRequestContext().getStage();
415-
}
416413

417414
public static ServletContext getInstance(AwsProxyRequest request, Context lambdaContext) {
418415
if (instance == null) {
@@ -421,8 +418,4 @@ public static ServletContext getInstance(AwsProxyRequest request, Context lambda
421418

422419
return instance;
423420
}
424-
425-
public static void clearServletContextCache() {
426-
instance = null;
427-
}
428421
}

aws-serverless-java-container-spring/src/main/java/com/amazonaws/serverless/proxy/spring/LambdaSpringApplicationInitializer.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ public class LambdaSpringApplicationInitializer implements WebApplicationInitial
4747
private ConfigurableWebApplicationContext applicationContext;
4848
private boolean refreshContext = true;
4949
private List<ServletContextListener> contextListeners;
50-
private String lambdaStage;
5150

5251
// Dynamically instantiated properties
5352
private ServletConfig dispatcherConfig;
@@ -85,13 +84,8 @@ public void dispatch(HttpServletRequest request, HttpServletResponse response)
8584
dispatcherServlet.service(request, response);
8685
}
8786

88-
public void setLambdaStage(String lambdaStage) {
89-
this.lambdaStage = lambdaStage;
90-
}
91-
9287
@Override
9388
public void onStartup(ServletContext servletContext) throws ServletException {
94-
applicationContext.getEnvironment().setActiveProfiles(lambdaStage);
9589
applicationContext.setServletContext(servletContext);
9690

9791
dispatcherConfig = new DefaultDispatcherConfig(servletContext);

aws-serverless-java-container-spring/src/main/java/com/amazonaws/serverless/proxy/spring/SpringLambdaContainerHandler.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@
1616
import com.amazonaws.serverless.proxy.internal.*;
1717
import com.amazonaws.serverless.proxy.internal.model.AwsProxyRequest;
1818
import com.amazonaws.serverless.proxy.internal.model.AwsProxyResponse;
19-
import com.amazonaws.serverless.proxy.internal.servlet.*;
19+
import com.amazonaws.serverless.proxy.internal.servlet.AwsHttpServletResponse;
20+
import com.amazonaws.serverless.proxy.internal.servlet.AwsProxyHttpServletRequest;
21+
import com.amazonaws.serverless.proxy.internal.servlet.AwsProxyHttpServletRequestReader;
22+
import com.amazonaws.serverless.proxy.internal.servlet.AwsProxyHttpServletResponseWriter;
2023
import com.amazonaws.services.lambda.runtime.Context;
2124
import org.springframework.web.context.ConfigurableWebApplicationContext;
2225
import org.springframework.web.context.support.AnnotationConfigWebApplicationContext;
@@ -109,7 +112,6 @@ protected void handleRequest(AwsProxyHttpServletRequest containerRequest, AwsHtt
109112

110113
// wire up the application context on the first invocation
111114
if (!initialized) {
112-
initializer.setLambdaStage(((AwsProxyServletContext) containerRequest.getServletContext()).getStage());
113115
ServletContext context = containerRequest.getServletContext();
114116
initializer.onStartup(context);
115117
initialized = true;

aws-serverless-java-container-spring/src/test/java/com/amazonaws/serverless/proxy/spring/echoapp/EchoSpringAppConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,18 @@
22

33
import com.amazonaws.serverless.exceptions.ContainerInitializationException;
44
import com.amazonaws.serverless.proxy.internal.testutils.MockLambdaContext;
5+
import com.amazonaws.serverless.proxy.spring.LambdaSpringApplicationInitializer;
56
import com.amazonaws.serverless.proxy.spring.SpringLambdaContainerHandler;
7+
import com.amazonaws.services.lambda.runtime.Context;
68
import com.fasterxml.jackson.databind.ObjectMapper;
79
import org.springframework.beans.factory.annotation.Autowired;
810
import org.springframework.context.annotation.Bean;
911
import org.springframework.context.annotation.ComponentScan;
1012
import org.springframework.context.annotation.Configuration;
11-
import org.springframework.context.annotation.PropertySource;
1213
import org.springframework.web.context.ConfigurableWebApplicationContext;
1314

1415
@Configuration
1516
@ComponentScan("com.amazonaws.serverless.proxy.spring.echoapp")
16-
@PropertySource("classpath:application.properties")
1717
public class EchoSpringAppConfig {
1818

1919
@Autowired

aws-serverless-java-container-spring/src/test/java/com/amazonaws/serverless/proxy/spring/echoapp/ProfileOverrideConfig.java

Lines changed: 0 additions & 14 deletions
This file was deleted.

aws-serverless-java-container-spring/src/test/java/com/amazonaws/serverless/proxy/spring/echoapp/profile/DefaultProfileConfiguration.java

Lines changed: 0 additions & 12 deletions
This file was deleted.

aws-serverless-java-container-spring/src/test/java/com/amazonaws/serverless/proxy/spring/echoapp/profile/DefaultProfileResource.java

Lines changed: 0 additions & 32 deletions
This file was deleted.

aws-serverless-java-container-spring/src/test/java/com/amazonaws/serverless/proxy/spring/echoapp/profile/OverrideProfileConfiguration.java

Lines changed: 0 additions & 14 deletions
This file was deleted.

aws-serverless-java-container-spring/src/test/java/com/amazonaws/serverless/proxy/spring/profile/SpringProfileTest.java

Lines changed: 0 additions & 72 deletions
This file was deleted.

0 commit comments

Comments
 (0)