Skip to content

Commit 916f2a2

Browse files
committed
Update unit tests to test decoding of query param names
1 parent 7c05a6f commit 916f2a2

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

aws-serverless-java-container-core/src/test/java/com/amazonaws/serverless/proxy/internal/servlet/AwsHttpServletRequestTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ public class AwsHttpServletRequestTest {
4040
private static final AwsProxyRequest queryStringEmptyValue = new AwsProxyRequestBuilder("/test", "GET")
4141
.queryString("one", "two").queryString("three", "").build();
4242
private static final AwsProxyRequest encodedQueryString = new AwsProxyRequestBuilder("/test", "GET")
43-
.queryString("one", "two").queryString("json", "{\"name\":\"faisal\"}").build();
43+
.queryString("one", "two").queryString("json value@1", "{\"name\":\"faisal\"}").build();
4444
private static final AwsProxyRequest encodedQueryStringAlb = new AwsProxyRequestBuilder("/test", "GET")
45-
.queryString("one", "two").queryString("json", "{\"name\":\"faisal\"}").alb().build();
45+
.queryString("one", "two").queryString("json value@1", "{\"name\":\"faisal\"}").alb().build();
4646
private static final AwsProxyRequest multipleParams = new AwsProxyRequestBuilder("/test", "GET")
47-
.queryString("one", "two").queryString("one", "three").queryString("json", "{\"name\":\"faisal\"}").build();
47+
.queryString("one", "two").queryString("one", "three").queryString("json value@1", "{\"name\":\"faisal\"}").build();
4848
private static final AwsProxyRequest formEncodedAndQueryString = new AwsProxyRequestBuilder("/test", "POST")
4949
.queryString("one", "two").queryString("one", "three")
5050
.queryString("five", "six")
@@ -229,7 +229,7 @@ void queryStringWithEncodedParams_generateQueryString_validQuery() {
229229
fail("Could not generate query string");
230230
}
231231
assertTrue(parsedString.contains("one=two"));
232-
assertTrue(parsedString.contains("json=%7B%22name%22%3A%22faisal%22%7D"));
232+
assertTrue(parsedString.contains("json+value%401=%7B%22name%22%3A%22faisal%22%7D"));
233233
assertTrue(parsedString.contains("&") && parsedString.indexOf("&") > 0 && parsedString.indexOf("&") < parsedString.length());
234234
}
235235

@@ -245,7 +245,7 @@ void queryStringWithEncodedParams_alb_generateQueryString_validQuery() {
245245
fail("Could not generate query string");
246246
}
247247
assertTrue(parsedString.contains("one=two"));
248-
assertTrue(parsedString.contains("json=%7B%22name%22%3A%22faisal%22%7D"));
248+
assertTrue(parsedString.contains("json+value%401=%7B%22name%22%3A%22faisal%22%7D"));
249249
assertTrue(parsedString.contains("&") && parsedString.indexOf("&") > 0 && parsedString.indexOf("&") < parsedString.length());
250250
}
251251

@@ -262,7 +262,7 @@ void queryStringWithMultipleValues_generateQueryString_validQuery() {
262262
}
263263
assertTrue(parsedString.contains("one=two"));
264264
assertTrue(parsedString.contains("one=three"));
265-
assertTrue(parsedString.contains("json=%7B%22name%22%3A%22faisal%22%7D"));
265+
assertTrue(parsedString.contains("json+value%401=%7B%22name%22%3A%22faisal%22%7D"));
266266
assertTrue(parsedString.contains("&") && parsedString.indexOf("&") > 0 && parsedString.indexOf("&") < parsedString.length());
267267
}
268268

@@ -327,7 +327,7 @@ void parameterMapWithEncodedParams_generateParameterMap_validQuery() {
327327
}
328328

329329
assertArrayEquals(new String[]{"two"}, paramMap.get("one"));
330-
assertArrayEquals(new String[]{"{\"name\":\"faisal\"}"}, paramMap.get("json"));
330+
assertArrayEquals(new String[]{"{\"name\":\"faisal\"}"}, paramMap.get("json value@1"));
331331
assertTrue(paramMap.size() == 2);
332332
}
333333

@@ -344,7 +344,7 @@ void parameterMapWithEncodedParams_alb_generateParameterMap_validQuery() {
344344
}
345345

346346
assertArrayEquals(new String[]{"two"}, paramMap.get("one"));
347-
assertArrayEquals(new String[]{"{\"name\":\"faisal\"}"}, paramMap.get("json"));
347+
assertArrayEquals(new String[]{"{\"name\":\"faisal\"}"}, paramMap.get("json value@1"));
348348
assertTrue(paramMap.size() == 2);
349349
}
350350

@@ -360,7 +360,7 @@ void parameterMapWithMultipleValues_generateParameterMap_validQuery() {
360360
fail("Could not generate parameter map");
361361
}
362362
assertArrayEquals(new String[]{"two", "three"}, paramMap.get("one"));
363-
assertArrayEquals(new String[]{"{\"name\":\"faisal\"}"}, paramMap.get("json"));
363+
assertArrayEquals(new String[]{"{\"name\":\"faisal\"}"}, paramMap.get("json value@1"));
364364
assertTrue(paramMap.size() == 2);
365365
}
366366

0 commit comments

Comments
 (0)