Skip to content

Commit 96b1a4a

Browse files
committed
Remove AwsLambdaServletContainerHandler from AwsAsyncContext since it is no longer dependent on AwsLambdaServletContainerHandler
1 parent 0982dc1 commit 96b1a4a

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsAsyncContext.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
public class AwsAsyncContext implements AsyncContext {
3333
private HttpServletRequest req;
3434
private HttpServletResponse res;
35-
private AwsLambdaServletContainerHandler handler;
3635
private List<AsyncListenerHolder> listeners;
3736
private long timeout;
3837
private AtomicBoolean dispatched;
@@ -41,11 +40,10 @@ public class AwsAsyncContext implements AsyncContext {
4140

4241
private Logger log = LoggerFactory.getLogger(AwsAsyncContext.class);
4342

44-
public AwsAsyncContext(HttpServletRequest request, HttpServletResponse response, AwsLambdaServletContainerHandler servletHandler) {
43+
public AwsAsyncContext(HttpServletRequest request, HttpServletResponse response) {
4544
log.debug("Initializing async context for request: " + SecurityUtils.crlf(request.getPathInfo()) + " - " + SecurityUtils.crlf(request.getMethod()));
4645
req = request;
4746
res = response;
48-
handler = servletHandler;
4947
listeners = new ArrayList<>();
5048
timeout = 3000;
5149
dispatched = new AtomicBoolean(false);

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsHttpApiV2ProxyHttpServletRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -442,15 +442,15 @@ public boolean isAsyncStarted() {
442442

443443
@Override
444444
public AsyncContext startAsync() throws IllegalStateException {
445-
asyncContext = new AwsAsyncContext(this, response, containerHandler);
445+
asyncContext = new AwsAsyncContext(this, response);
446446
setAttribute(DISPATCHER_TYPE_ATTRIBUTE, DispatcherType.ASYNC);
447447
log.debug("Starting async context for request: " + SecurityUtils.crlf(request.getRequestContext().getRequestId()));
448448
return asyncContext;
449449
}
450450

451451
@Override
452452
public AsyncContext startAsync(ServletRequest servletRequest, ServletResponse servletResponse) throws IllegalStateException {
453-
asyncContext = new AwsAsyncContext((HttpServletRequest) servletRequest, (HttpServletResponse) servletResponse, containerHandler);
453+
asyncContext = new AwsAsyncContext((HttpServletRequest) servletRequest, (HttpServletResponse) servletResponse);
454454
setAttribute(DISPATCHER_TYPE_ATTRIBUTE, DispatcherType.ASYNC);
455455
log.debug("Starting async context for request: " + SecurityUtils.crlf(request.getRequestContext().getRequestId()));
456456
return asyncContext;

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsProxyHttpServletRequest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ public boolean isAsyncStarted() {
495495
@Override
496496
public AsyncContext startAsync()
497497
throws IllegalStateException {
498-
asyncContext = new AwsAsyncContext(this, response, containerHandler);
498+
asyncContext = new AwsAsyncContext(this, response);
499499
setAttribute(DISPATCHER_TYPE_ATTRIBUTE, DispatcherType.ASYNC);
500500
log.debug("Starting async context for request: " + SecurityUtils.crlf(request.getRequestContext().getRequestId()));
501501
return asyncContext;
@@ -506,7 +506,7 @@ public AsyncContext startAsync()
506506
public AsyncContext startAsync(ServletRequest servletRequest, ServletResponse servletResponse)
507507
throws IllegalStateException {
508508
servletRequest.setAttribute(DISPATCHER_TYPE_ATTRIBUTE, DispatcherType.ASYNC);
509-
asyncContext = new AwsAsyncContext((HttpServletRequest) servletRequest, (HttpServletResponse) servletResponse, containerHandler);
509+
asyncContext = new AwsAsyncContext((HttpServletRequest) servletRequest, (HttpServletResponse) servletResponse);
510510
log.debug("Starting async context for request: " + SecurityUtils.crlf(request.getRequestContext().getRequestId()));
511511
return asyncContext;
512512
}

0 commit comments

Comments
 (0)