Skip to content

Commit a96edd6

Browse files
authored
Merge pull request #205 from tjordahl/master
Fix Multipart form processing: IllegalArgumentException: File path not allowed
2 parents 05aeb79 + 22101e1 commit a96edd6

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsProxyHttpServletRequest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import org.apache.commons.fileupload.FileUploadException;
2626
import org.apache.commons.fileupload.disk.DiskFileItemFactory;
2727
import org.apache.commons.fileupload.servlet.ServletFileUpload;
28+
import org.apache.commons.io.FilenameUtils;
2829
import org.apache.commons.io.IOUtils;
2930
import org.apache.commons.io.input.NullInputStream;
3031
import org.slf4j.Logger;
@@ -685,7 +686,7 @@ private String[] getFormBodyParameterCaseInsensitive(String key) {
685686
}
686687

687688

688-
@SuppressFBWarnings("FILE_UPLOAD_FILENAME")
689+
@SuppressFBWarnings({"FILE_UPLOAD_FILENAME", "WEAK_FILENAMEUTILS"})
689690
private Map<String, Part> getMultipartFormParametersMap() {
690691
if (multipartFormParameters != null) {
691692
return multipartFormParameters;
@@ -701,7 +702,7 @@ private Map<String, Part> getMultipartFormParametersMap() {
701702
try {
702703
List<FileItem> items = upload.parseRequest(this);
703704
for (FileItem item : items) {
704-
String fileName = SecurityUtils.getValidFilePath(item.getName(), true);
705+
String fileName = FilenameUtils.getName(item.getName());
705706
AwsProxyRequestPart newPart = new AwsProxyRequestPart(item.get());
706707
newPart.setName(fileName);
707708
newPart.setSubmittedFileName(item.getFieldName());

0 commit comments

Comments
 (0)