Skip to content

Commit b9f486e

Browse files
committed
Add a bit of test coverage, and a toString for logging
1 parent 5483a9c commit b9f486e

File tree

4 files changed

+57
-0
lines changed

4 files changed

+57
-0
lines changed

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/model/AwsProxyRequest.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,4 +155,20 @@ public boolean isBase64Encoded() {
155155
public void setBase64Encoded(boolean base64Encoded) {
156156
isBase64Encoded = base64Encoded;
157157
}
158+
159+
@Override
160+
public String toString() {
161+
return "AwsProxyRequest{" +
162+
"body='" + body + '\'' +
163+
", resource='" + resource + '\'' +
164+
", requestContext=" + requestContext +
165+
", queryStringParameters=" + queryStringParameters +
166+
", headers=" + headers +
167+
", pathParameters=" + pathParameters +
168+
", httpMethod='" + httpMethod + '\'' +
169+
", stageVariables=" + stageVariables +
170+
", path='" + path + '\'' +
171+
", isBase64Encoded=" + isBase64Encoded +
172+
'}';
173+
}
158174
}

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/testutils/AwsProxyRequestBuilder.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ public AwsProxyRequestBuilder method(String httpMethod) {
6868
return this;
6969
}
7070

71+
// public AwsProxyRequestBuilder schemeAndHost(String scheme) {
72+
// this.request.getRequestContext().
73+
// }
7174

7275
public AwsProxyRequestBuilder path(String path) {
7376
this.request.setPath(path);

aws-serverless-java-container-spring/src/test/java/com/amazonaws/serverless/proxy/spring/SpringAwsProxyTest.java

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,28 @@ public void servletRequestEncoding_acceptEncoding_okStatusCode() {
187187
assertEquals(200, output.getStatusCode());
188188
}
189189

190+
@Test
191+
public void request_requestURI() {
192+
AwsProxyRequest request = new AwsProxyRequestBuilder("/echo/request-URI", "GET")
193+
.build();
194+
195+
AwsProxyResponse output = handler.proxy(request, lambdaContext);
196+
assertEquals(200, output.getStatusCode());
197+
198+
validateSingleValueModel(output, "/echo/request-URI");
199+
}
200+
201+
@Test
202+
public void request_requestURL() {
203+
AwsProxyRequest request = new AwsProxyRequestBuilder("/echo/request-URL", "GET")
204+
.build();
205+
206+
AwsProxyResponse output = handler.proxy(request, lambdaContext);
207+
assertEquals(200, output.getStatusCode());
208+
209+
// validateSingleValueModel(output, "/echo/request-URI");
210+
}
211+
190212
private void validateMapResponseModel(AwsProxyResponse output) {
191213
try {
192214
MapResponseModel response = objectMapper.readValue(output.getBody(), MapResponseModel.class);

aws-serverless-java-container-spring/src/test/java/com/amazonaws/serverless/proxy/spring/echoapp/EchoResource.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,4 +83,20 @@ public ResponseEntity<byte[]> echoBinaryData() {
8383

8484
return new ResponseEntity<byte[]>(b, HttpStatus.OK);
8585
}
86+
87+
@RequestMapping(path = "/request-URI", method = RequestMethod.GET)
88+
public SingleValueModel echoRequestURI(HttpServletRequest request) {
89+
SingleValueModel valueModel = new SingleValueModel();
90+
valueModel.setValue(request.getRequestURI());
91+
92+
return valueModel;
93+
}
94+
95+
@RequestMapping(path = "/request-URL", method = RequestMethod.GET)
96+
public SingleValueModel echoRequestURL(HttpServletRequest request) {
97+
SingleValueModel valueModel = new SingleValueModel();
98+
valueModel.setValue(request.getRequestURL().toString());
99+
100+
return valueModel;
101+
}
86102
}

0 commit comments

Comments
 (0)