Skip to content

Commit cf8abfe

Browse files
authored
Revert "Fixing the cookies field in the v2 request object."
1 parent d1a396f commit cf8abfe

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsHttpApiV2ProxyHttpServletRequest.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,6 @@ public String getAuthType() {
7575

7676
@Override
7777
public Cookie[] getCookies() {
78-
if (request.getCookies() != null && !request.getCookies().isEmpty()) {
79-
return request.getCookies().stream()
80-
.map(cookie -> cookie.split("=", 2))
81-
.map(parts -> new Cookie(SecurityUtils.crlf(parts[0]), SecurityUtils.crlf(parts[1])))
82-
.toArray(Cookie[]::new);
83-
}
84-
8578
if (headers == null || !headers.containsKey(HttpHeaders.COOKIE)) {
8679
return new Cookie[0];
8780
}

aws-serverless-java-container-core/src/test/java/com/amazonaws/serverless/proxy/internal/servlet/AwsHttpApiV2HttpServletRequestReaderTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import com.amazonaws.serverless.proxy.model.HttpApiV2ProxyRequestContext;
88
import org.junit.Test;
99

10-
import javax.servlet.http.Cookie;
1110
import javax.servlet.http.HttpServletRequest;
1211

1312
import static org.junit.Assert.*;
@@ -26,18 +25,13 @@ public void baseRequest_read_populatesSuccessfully() {
2625
.referer("localhost")
2726
.queryString("param1", "value1")
2827
.header("custom", "value")
29-
.cookie("_cookie", "baked")
3028
.apiId("test").toHttpApiV2Request();
3129
AwsHttpApiV2HttpServletRequestReader reader = new AwsHttpApiV2HttpServletRequestReader();
3230
try {
3331
HttpServletRequest servletRequest = reader.readRequest(req, null, null, LambdaContainerHandler.getContainerConfig());
3432
assertEquals("/hello", servletRequest.getPathInfo());
3533
assertEquals("value1", servletRequest.getParameter("param1"));
3634
assertEquals("value", servletRequest.getHeader("CUSTOM"));
37-
Cookie[] cookies = servletRequest.getCookies();
38-
assertEquals(1, cookies.length);
39-
assertEquals("_cookie", cookies[0].getName());
40-
assertEquals("baked", cookies[0].getValue());
4135

4236
assertNotNull(servletRequest.getAttribute(AwsHttpApiV2HttpServletRequestReader.HTTP_API_CONTEXT_PROPERTY));
4337
assertEquals("test",

0 commit comments

Comments
 (0)