Collections.emptyList() should be used over EMPTY_LIST to prevent unchecked warnings.

Steve Peters · Steve Peters · commit f94da5a1e6db · 2019-02-07T09:59:48.000-06:00
diff --git a/aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsProxyRequestPart.java b/aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsProxyRequestPart.java
@@ -117,7 +117,7 @@ public String getHeader(String s) {
     @Override
     public Collection<String> getHeaders(String s) {
         if (headers == null) {
-            return Collections.EMPTY_LIST;
+            return Collections.emptyList();
         }
         return headers.get(s);
     }
@@ -126,7 +126,7 @@ public Collection<String> getHeaders(String s) {
     @Override
     public Collection<String> getHeaderNames() {
         if (headers == null) {
-            return Collections.EMPTY_LIST;
+            return Collections.emptyList();
         }
         return headers.keySet();
     }

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ public String getHeader(String s) {`
`117`	`117`	`@Override`
`118`	`118`	`public Collection<String> getHeaders(String s) {`
`119`	`119`	`if (headers == null) {`
`120`		`- return Collections.EMPTY_LIST;`
	`120`	`+ return Collections.emptyList();`
`121`	`121`	`}`
`122`	`122`	`return headers.get(s);`
`123`	`123`	`}`
`@@ -126,7 +126,7 @@ public Collection<String> getHeaders(String s) {`
`126`	`126`	`@Override`
`127`	`127`	`public Collection<String> getHeaderNames() {`
`128`	`128`	`if (headers == null) {`
`129`		`- return Collections.EMPTY_LIST;`
	`129`	`+ return Collections.emptyList();`
`130`	`130`	`}`
`131`	`131`	`return headers.keySet();`
`132`	`132`	`}`