Skip to content

Commit fc79040

Browse files
committed
- extracted variable for request.getQueryStringParameters() according to comments in PR
1 parent 4fcfb3a commit fc79040

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

aws-serverless-java-container-core/src/main/java/com/amazonaws/serverless/proxy/internal/servlet/AwsProxyHttpServletRequest.java

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -529,9 +529,8 @@ public String getParameter(String s) {
529529
@Override
530530
public Enumeration<String> getParameterNames() {
531531
List<String> paramNames = new ArrayList<>();
532-
Map<String, String> queryStringParameters = request.getQueryStringParameters();
533-
if (queryStringParameters != null) {
534-
paramNames.addAll(queryStringParameters.keySet());
532+
if (request.getQueryStringParameters() != null) {
533+
paramNames.addAll(request.getQueryStringParameters().keySet());
535534
}
536535
paramNames.addAll(urlEncodedFormParameters.keySet());
537536
return Collections.enumeration(paramNames);
@@ -570,9 +569,8 @@ public Map<String, String[]> getParameterMap() {
570569
params = new HashMap<>();
571570
}
572571

573-
Map<String, String> queryStringParameters = request.getQueryStringParameters();
574-
if (queryStringParameters != null) {
575-
for (Map.Entry<String, String> entry : queryStringParameters.entrySet()) {
572+
if (request.getQueryStringParameters() != null) {
573+
for (Map.Entry<String, String> entry : request.getQueryStringParameters().entrySet()) {
576574
if (params.containsKey(entry.getKey())) {
577575
params.get(entry.getKey()).add(entry.getValue());
578576
} else {
@@ -786,14 +784,13 @@ private String getHeaderCaseInsensitive(String key) {
786784

787785

788786
private String getQueryStringParameterCaseInsensitive(String key) {
789-
Map<String, String> queryStringParameters = request.getQueryStringParameters();
790-
if (queryStringParameters == null) {
787+
if (request.getQueryStringParameters() == null) {
791788
return null;
792789
}
793790

794-
for (String requestParamKey : queryStringParameters.keySet()) {
791+
for (String requestParamKey : request.getQueryStringParameters().keySet()) {
795792
if (key.toLowerCase().equals(requestParamKey.toLowerCase())) {
796-
return queryStringParameters.get(requestParamKey);
793+
return request.getQueryStringParameters().get(requestParamKey);
797794
}
798795
}
799796
return null;

0 commit comments

Comments
 (0)