Skip to content

Safely split example IDs for filling missing fields #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Safely split example IDs for filling missing fields #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions aws_doc_sdk_examples_tools/doc_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,15 @@ def validate(self):
)

def fill_missing_fields(self):
def safe_split_id(ex_id: str) -> Tuple[str, str]:
if "_" in example.id:
svc, act = ex_id.split("_", 1)
else:
svc, act = "unknown_service", "unknown_action"
return svc, act

for example in self.examples.values():
id_service, id_action = example.id.split("_", 1)
id_service, id_action = safe_split_id(example.id)
service_id = example.service_main or next(
(k for (k, _) in example.services.items()), None
)
Expand All @@ -274,7 +281,7 @@ def fill_missing_fields(self):
service_id = id_service
action = (
next((k for k in example.services.get(service_id, [])), None)
or example.id.split("_", 1)[1]
or safe_split_id(example.id)[1]
)
if action is None:
# TODO Log and find which tributaries this effects, as it was supposed to be caught by validations.
Expand Down
Loading