Abstract filesystem operations in snippets.py #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpyle0819
force-pushed
the
iteration-3-snippets
branch
from
4c6ce14 to
ca0e870
Compare
DavidSouther
requested changes
Jul 7, 2025
cpyle0819
force-pushed
the
iteration-3-snippets
branch
from
ca0e870 to
81a104e
Compare
- Add fs parameter to collect_snippets, find_snippets, and collect_snippet_files functions - Replace direct filesystem calls with Fs interface methods: - Use fs.readlines() instead of open().readlines() - Use fs.stat() instead of path.exists() - Fix PathFs to use UTF-8 encoding for all file operations (read, readlines, write) - Add comprehensive tests using RecordFs for deterministic testing - Test snippet collection, file handling, and error cases with filesystem abstraction
- Update Fs abstract method to accept encoding parameter with utf-8 default - Update PathFs and RecordFs implementations to support encoding parameter - Maintains backward compatibility with default utf-8 encoding - Addresses PR feedback for Python 3.9 and earlier compatibility
cpyle0819
force-pushed
the
iteration-3-snippets
branch
from
81a104e to
bfc932a
Compare
DavidSouther
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #179 and abstracts filesystem operations in snippets.py.
Changes
fs: Fsparameter tocollect_snippets,find_snippets, andcollect_snippet_filesfunctionsfs.readlines()instead ofopen().readlines()fs.stat()instead ofpath.exists()PathFsto use UTF-8 encoding for all file operations (read,readlines,write)Testing
Dependencies