Skip to content

Commit 0d05e83

Browse files
authored
Go: Update all bucket name uses to user input, env vars, or approved names. (#6970)
Update all bucket name uses to user input, env vars, or approved names.
1 parent e837d87 commit 0d05e83

File tree

16 files changed

+68
-41
lines changed

16 files changed

+68
-41
lines changed

gov2/cloudfront/CreateDistribution/CreateDistribution.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ var (
149149
// and config files.
150150
func main() {
151151

152-
flag.StringVar(&bucketName, "bucket", "", "<EXAMPLE-BUCKET-NAME>")
152+
flag.StringVar(&bucketName, "bucket", "", "amzn-s3-demo-bucket")
153153
flag.StringVar(&certificateSSLArn, "cert", "", "<AWS CERTIFICATE MANGER ARN>")
154154
flag.StringVar(&domain, "domain", "", "<YOUR DOMAIN>")
155155
flag.Parse()

gov2/cloudfront/CreateDistribution/CreateDistribution_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ func TestCreateDistribution(t *testing.T) {
6868

6969
mockCFDistribution := createMockCFDistribution(s3Client, cloudfrontClient)
7070

71-
bucketName := "example-com"
71+
bucketName := "amzn-s3-demo-bucket"
7272
certificateSSLArn := "arn:aws:acm:ap-northeast-2:123456789000:certificate/000000000-0000-0000-0000-000000000000"
7373
domain := "example.com"
7474

gov2/iam/scenarios/scenario_assume_role_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func (scenTest *AssumeRoleScenarioTest) SetupDataAndStubs() []testtools.Stub {
6060
&testtools.StubError{Err: &smithy.GenericAPIError{Code: "AccessDenied"}, ContinueAfter: true}))
6161
stubList = append(stubList, stubs.StubAssumeRole(roleArn, "AssumeRoleExampleSession",
6262
900, keyId, keySecret, token, nil))
63-
stubList = append(stubList, stubs.StubListBuckets([]string{"test-bucket-1", "test-bucket-2"}, nil))
63+
stubList = append(stubList, stubs.StubListBuckets([]string{"amzn-s3-demo-bucket-1", "amzn-s3-demo-bucket-2"}, nil))
6464
stubList = append(stubList, stubs.StubListAttachedRolePolicies(roleName,
6565
map[string]string{listBucketsPolicy: listBucketsPolicyArn}, nil))
6666
stubList = append(stubList, stubs.StubDetachRolePolicy(roleName, listBucketsPolicyArn, nil))

gov2/s3/actions/bucket_basics_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ func TestBucketBasics_CopyToBucket(t *testing.T) {
2828

2929
func CopyToBucket(raiseErr *testtools.StubError, t *testing.T) {
3030
stubber, basics := enterTest()
31-
stubber.Add(stubs.StubCopyObject("source-bucket", "object-key", "dest-bucket", "object-key", raiseErr))
31+
stubber.Add(stubs.StubCopyObject("amzn-s3-demo-bucket-source", "object-key", "amzn-s3-demo-bucket-dest", "object-key", raiseErr))
3232
ctx := context.Background()
3333

34-
err := basics.CopyToBucket(ctx, "source-bucket", "dest-bucket", "object-key")
34+
err := basics.CopyToBucket(ctx, "amzn-s3-demo-bucket-source", "amzn-s3-demo-bucket-dest", "object-key")
3535

3636
testtools.VerifyError(err, raiseErr, t)
3737
testtools.ExitTest(stubber, t)

gov2/s3/go.mod

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ require (
2727
github.com/aws/aws-sdk-go-v2/service/sso v1.22.7 // indirect
2828
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.26.7 // indirect
2929
github.com/aws/aws-sdk-go-v2/service/sts v1.30.7 // indirect
30+
github.com/google/uuid v1.6.0 // indirect
3031
golang.org/x/sys v0.25.0 // indirect
3132
golang.org/x/term v0.24.0 // indirect
3233
)

gov2/s3/go.sum

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ github.com/awsdocs/aws-doc-sdk-examples/gov2/demotools v0.0.0-20240907001412-a93
4040
github.com/awsdocs/aws-doc-sdk-examples/gov2/demotools v0.0.0-20240907001412-a9375541143b/go.mod h1:iBzksyiv5HVU+cymGDQbbvcecca+rsARJlDFL8np8oE=
4141
github.com/awsdocs/aws-doc-sdk-examples/gov2/testtools v0.0.0-20240907001412-a9375541143b h1:UmPy4pArM7SIhTX2Xn5bhOkgI9onSUQ1Y9fxgDJ3pHU=
4242
github.com/awsdocs/aws-doc-sdk-examples/gov2/testtools v0.0.0-20240907001412-a9375541143b/go.mod h1:9Oj/8PZn3D5Ftp/Z1QWrIEFE0daERMqfJawL9duHRfc=
43+
github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
44+
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
4345
golang.org/x/sys v0.25.0 h1:r+8e+loiHxRqhXVl6ML1nO3l1+oFoWbnlu2Ehimmi34=
4446
golang.org/x/sys v0.25.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
4547
golang.org/x/term v0.24.0 h1:Mh5cbb+Zk2hqqXNO7S1iTjEphVL+jb8ZWaqh/g+JWkM=

gov2/s3/scenarios/scenario_get_started_integ_test.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,29 +3,35 @@
33
//go:build integration
44
// +build integration
55

6-
// SPDX-License-Identifier: Apache-2.0
7-
86
// Integration test for the Amazon S3 get started scenario.
97

108
package scenarios
119

1210
import (
1311
"bytes"
1412
"context"
13+
"fmt"
1514
"log"
1615
"os"
1716
"strings"
1817
"testing"
1918

2019
"github.com/aws/aws-sdk-go-v2/config"
2120
"github.com/awsdocs/aws-doc-sdk-examples/gov2/demotools"
21+
"github.com/google/uuid"
2222
)
2323

2424
func TestGetStartedScenario_Integration(t *testing.T) {
25+
bucket := os.Getenv("S3_BUCKET_NAME_PREFIX")
26+
if bucket == "" {
27+
bucket = "amzn-s3-demo-bucket"
28+
} else {
29+
bucket = fmt.Sprintf("%s-%s", bucket, uuid.New())
30+
}
2531
outFile := "integ-test.out"
2632
mockQuestioner := &demotools.MockQuestioner{
2733
Answers: []string{
28-
"doc-example-go-test-bucket", "../README.md", "", outFile, "", "test-folder", "", "y",
34+
bucket, "../README.md", "", outFile, "", "test-folder", "", "y",
2935
},
3036
}
3137

gov2/s3/scenarios/scenario_get_started_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ type GetStartedScenarioTest struct {
5050
// SetupDataAndStubs sets up test data and builds the stubs that are used to return
5151
// mocked data.
5252
func (scenTest *GetStartedScenarioTest) SetupDataAndStubs() []testtools.Stub {
53-
bucketName := "test-bucket-1"
53+
bucketName := "amzn-s3-demo-bucket-1"
5454
objectKey := "doc-example-key"
5555
largeKey := "doc-example-large"
56-
bucketList := []types.Bucket{{Name: aws.String(bucketName)}, {Name: aws.String("test-bucket-2")}}
56+
bucketList := []types.Bucket{{Name: aws.String(bucketName)}, {Name: aws.String("amzn-s3-demo-bucket-2")}}
5757
testConfig, err := config.LoadDefaultConfig(context.TODO())
5858
if err != nil {
5959
panic(err)

gov2/s3/scenarios/scenario_presigning_integ_test.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,27 @@ package scenarios
1212
import (
1313
"bytes"
1414
"context"
15+
"fmt"
1516
"log"
1617
"os"
1718
"strings"
1819
"testing"
1920

2021
"github.com/aws/aws-sdk-go-v2/config"
2122
"github.com/awsdocs/aws-doc-sdk-examples/gov2/demotools"
23+
"github.com/google/uuid"
2224
)
2325

2426
func TestRunPresigningScenario_Integration(t *testing.T) {
27+
bucket := os.Getenv("S3_BUCKET_NAME_PREFIX")
28+
if bucket == "" {
29+
bucket = "amzn-s3-demo-bucket"
30+
} else {
31+
bucket = fmt.Sprintf("%s-%s", bucket, uuid.New())
32+
}
2533
mockQuestioner := &demotools.MockQuestioner{
2634
Answers: []string{
27-
"doc-example-go-test-bucket", "../README.md", "test-object", "", "", "",
35+
bucket, "../README.md", "test-object", "", "", "",
2836
},
2937
}
3038

gov2/s3/scenarios/scenario_presigning_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ type PresigningScenarioTest struct {
5454
// SetupDataAndStubs sets up test data and builds the stubs that are used to return
5555
// mocked data.
5656
func (scenTest *PresigningScenarioTest) SetupDataAndStubs() []testtools.Stub {
57-
bucketName := "test-bucket-1"
57+
bucketName := "amzn-s3-demo-bucket-1"
5858
testConfig, err := config.LoadDefaultConfig(context.TODO())
5959
if err != nil {
6060
panic(err)

0 commit comments

Comments
 (0)