Skip to content

Commit 40b2996

Browse files
committed
added logging functionality
1 parent c400a58 commit 40b2996

File tree

3 files changed

+38
-34
lines changed

3 files changed

+38
-34
lines changed

kotlin/services/kms/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ dependencies {
3535
implementation("com.google.code.gson:gson:2.10")
3636
testImplementation("org.junit.jupiter:junit-jupiter:5.9.2")
3737
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4")
38+
implementation("org.slf4j:slf4j-api:2.0.15")
39+
implementation("org.slf4j:slf4j-simple:2.0.15")
3840
}
3941
tasks.withType<KotlinCompile> {
4042
kotlinOptions.jvmTarget = "17"

kotlin/services/kms/src/test/kotlin/KMSKotlinTest.kt

Lines changed: 25 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
import aws.sdk.kotlin.runtime.auth.credentials.EnvironmentCredentialsProvider
54
import aws.sdk.kotlin.services.secretsmanager.SecretsManagerClient
65
import aws.sdk.kotlin.services.secretsmanager.model.GetSecretValueRequest
76
import com.google.gson.Gson
@@ -28,10 +27,13 @@ import org.junit.jupiter.api.Order
2827
import org.junit.jupiter.api.Test
2928
import org.junit.jupiter.api.TestInstance
3029
import org.junit.jupiter.api.TestMethodOrder
30+
import org.slf4j.Logger
31+
import org.slf4j.LoggerFactory
3132

3233
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
3334
@TestMethodOrder(MethodOrderer.OrderAnnotation::class)
3435
class KMSKotlinTest {
36+
private val logger: Logger = LoggerFactory.getLogger(KMSKotlinTest::class.java)
3537
private var keyId = "" // gets set in test 2
3638
private var keyDesc = ""
3739
private var granteePrincipal = ""
@@ -50,16 +52,6 @@ class KMSKotlinTest {
5052
operation = values.operation.toString()
5153
aliasName = values.aliasName.toString()
5254
granteePrincipal = values.granteePrincipal.toString()
53-
54-
/*
55-
val input: InputStream = this.javaClass.getClassLoader().getResourceAsStream("config.properties")
56-
val prop = Properties()
57-
prop.load(input)
58-
keyDesc = prop.getProperty("keyDesc")
59-
granteePrincipal = prop.getProperty("granteePrincipal")
60-
operation = prop.getProperty("operation")
61-
aliasName = prop.getProperty("aliasName")
62-
*/
6355
}
6456

6557
@Test
@@ -68,98 +60,98 @@ class KMSKotlinTest {
6860
runBlocking {
6961
keyId = createKey(keyDesc).toString()
7062
Assertions.assertTrue(!keyId.isEmpty())
71-
println("Test 2 passed")
63+
logger.info("Test 2 passed")
7264
}
7365

7466
@Test
75-
@Order(3)
67+
@Order(2)
7668
fun encryptDataKeyTest() =
7769
runBlocking {
7870
val plaintext = "Hello, AWS KMS!"
7971
val encryptData = encryptData(keyId)
8072
decryptData(encryptData, keyId)
81-
println("Test 3 passed")
73+
logger.info("Test 2 passed")
8274
}
8375

8476
@Test
85-
@Order(4)
77+
@Order(3)
8678
fun disableCustomerKeyTest() =
8779
runBlocking {
8880
disableKey(keyId)
89-
println("Test 4 passed")
81+
logger.info("Test 3 passed")
9082
}
9183

9284
@Test
93-
@Order(5)
85+
@Order(4)
9486
fun enableCustomerKeyTest() =
9587
runBlocking {
9688
enableKey(keyId)
97-
println("Test 5 passed")
89+
logger.info("Test 4 passed")
9890
}
9991

10092
@Test
101-
@Order(6)
93+
@Order(5)
10294
fun createGrantTest() =
10395
runBlocking {
10496
grantId = createNewGrant(keyId, granteePrincipal, operation).toString()
10597
Assertions.assertTrue(!grantId.isEmpty())
106-
println("Test 6 passed")
98+
logger.info("Test 5 passed")
10799
}
108100

109101
@Test
110-
@Order(7)
102+
@Order(6)
111103
fun listGrantsTest() =
112104
runBlocking {
113105
displayGrantIds(keyId)
114-
println("Test 7 passed")
106+
logger.info("Test 6 passed")
115107
}
116108

117109
@Test
118-
@Order(8)
110+
@Order(7)
119111
fun revokeGrantsTest() =
120112
runBlocking {
121113
revokeKeyGrant(keyId, grantId)
122-
println("Test 8 passed")
114+
logger.info("Test 7 passed")
123115
}
124116

125117
@Test
126118
@Order(9)
127119
fun describeKeyTest() =
128120
runBlocking {
129121
describeSpecifcKey(keyId)
130-
println("Test 9 passed")
122+
logger.info("Test 8 passed")
131123
}
132124

133125
@Test
134-
@Order(10)
126+
@Order(9)
135127
fun createAliasTest() =
136128
runBlocking {
137129
createCustomAlias(keyId, aliasName)
138-
println("Test 10 passed")
130+
logger.info("Test 9 passed")
139131
}
140132

141133
@Test
142-
@Order(11)
134+
@Order(10)
143135
fun listAliasesTest() =
144136
runBlocking {
145137
listAllAliases()
146-
println("Test 11 passed")
138+
logger.info("Test 10 passed")
147139
}
148140

149141
@Test
150-
@Order(12)
142+
@Order(11)
151143
fun deleteAliasTest() =
152144
runBlocking {
153145
deleteSpecificAlias(aliasName)
154-
println("Test 12 passed")
146+
logger.info("Test 11 passed")
155147
}
156148

157149
@Test
158-
@Order(13)
150+
@Order(12)
159151
fun listKeysTest() =
160152
runBlocking {
161153
listAllKeys()
162-
println("Test 13 passed")
154+
logger.info("Test 12 passed")
163155
}
164156

165157
private suspend fun getSecretValues(): String {
@@ -170,7 +162,6 @@ class KMSKotlinTest {
170162
}
171163
SecretsManagerClient {
172164
region = "us-east-1"
173-
credentialsProvider = EnvironmentCredentialsProvider()
174165
}.use { secretClient ->
175166
val valueResponse = secretClient.getSecretValue(valueRequest)
176167
return valueResponse.secretString.toString()
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<configuration>
2+
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
3+
<encoder>
4+
<pattern>%d{yyyy-MM-dd HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
5+
</encoder>
6+
</appender>
7+
8+
<root level="info">
9+
<appender-ref ref="STDOUT"/>
10+
</root>
11+
</configuration>

0 commit comments

Comments
 (0)