Skip to content

Commit 5af96a0

Browse files
committed
added logging functionality
1 parent 690f7f7 commit 5af96a0

File tree

4 files changed

+35
-32
lines changed

4 files changed

+35
-32
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<configuration>
2+
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
3+
<encoder>
4+
<pattern>%d{yyyy-MM-dd HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
5+
</encoder>
6+
</appender>
7+
8+
<root level="info">
9+
<appender-ref ref="STDOUT"/>
10+
</root>
11+
</configuration>

kotlin/services/sagemaker/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ dependencies {
3535
implementation("com.google.code.gson:gson:2.10")
3636
testImplementation("org.junit.jupiter:junit-jupiter:5.9.2")
3737
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4")
38+
implementation("org.slf4j:slf4j-api:2.0.15")
39+
implementation("org.slf4j:slf4j-simple:2.0.15")
3840
}
3941
tasks.withType<KotlinCompile> {
4042
kotlinOptions.jvmTarget = "17"

kotlin/services/sagemaker/src/test/kotlin/SageMakerTest.kt

Lines changed: 11 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
import aws.sdk.kotlin.runtime.auth.credentials.EnvironmentCredentialsProvider
54
import aws.sdk.kotlin.services.secretsmanager.SecretsManagerClient
65
import aws.sdk.kotlin.services.secretsmanager.model.GetSecretValueRequest
76
import com.google.gson.Gson
@@ -22,11 +21,14 @@ import org.junit.jupiter.api.Order
2221
import org.junit.jupiter.api.Test
2322
import org.junit.jupiter.api.TestInstance
2423
import org.junit.jupiter.api.TestMethodOrder
24+
import org.slf4j.Logger
25+
import org.slf4j.LoggerFactory
2526
import java.util.UUID
2627

2728
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
2829
@TestMethodOrder(OrderAnnotation::class)
2930
class SageMakerTest {
31+
private val logger: Logger = LoggerFactory.getLogger(SageMakerTest::class.java)
3032
private var image = ""
3133
private var modelDataUrl = ""
3234
private var executionRoleArn = ""
@@ -57,92 +59,70 @@ class SageMakerTest {
5759
s3OutputPath = values.s3OutputPath.toString()
5860
channelName = values.channelName.toString()
5961
trainingImage = values.trainingImage.toString()
60-
61-
// Uncomment this code block if you prefer using a config.properties file to retrieve AWS values required for these tests.
62-
63-
/*
64-
val input: InputStream = this.javaClass.getClassLoader().getResourceAsStream("config.properties")
65-
val prop = Properties()
66-
prop.load(input)
67-
image = prop.getProperty("image")
68-
modelDataUrl = prop.getProperty("modelDataUrl")
69-
executionRoleArn = prop.getProperty("executionRoleArn")
70-
modelName = prop.getProperty("modelName")
71-
s3UriData = prop.getProperty("s3UriData")
72-
s3Uri = prop.getProperty("s3Uri")
73-
roleArn = prop.getProperty("roleArn")
74-
trainingJobName = prop.getProperty("trainingJobName")
75-
s3OutputPath = prop.getProperty("s3OutputPath")
76-
channelName = prop.getProperty("channelName")
77-
trainingImage = prop.getProperty("trainingImage")
78-
s3UriTransform = prop.getProperty("s3UriTransform")
79-
s3OutputPathTransform = prop.getProperty("s3OutputPathTransform")
80-
transformJobName = prop.getProperty("transformJobName")
81-
*/
8262
}
8363

8464
@Test
8565
@Order(1)
8666
fun createModelTest() =
8767
runBlocking {
8868
createSagemakerModel(modelDataUrl, image, modelName, executionRoleArn)
89-
println("Test 1 passed")
69+
logger.info("Test 1 passed")
9070
}
9171

9272
@Test
9373
@Order(2)
9474
fun createTrainingJobTest() =
9575
runBlocking {
9676
trainJob(s3UriData, s3Uri, trainingJobName, roleArn, s3OutputPath, channelName, trainingImage)
97-
println("Test 2 passed")
77+
logger.info("Test 2 passed")
9878
}
9979

10080
@Test
10181
@Order(3)
10282
fun describeTrainingJobTest() =
10383
runBlocking {
10484
describeTrainJob(trainingJobName)
105-
println("Test 3 passed")
85+
logger.info("Test 3 passed")
10686
}
10787

10888
@Test
10989
@Order(4)
11090
fun listModelsTest() =
11191
runBlocking {
11292
listAllModels()
113-
println("Test 4 passed")
93+
logger.info("Test 4 passed")
11494
}
11595

11696
@Test
11797
@Order(5)
11898
fun listNotebooksTest() =
11999
runBlocking {
120100
listBooks()
121-
println("Test 5 passed")
101+
logger.info("Test 5 passed")
122102
}
123103

124104
@Test
125105
@Order(6)
126106
fun listAlgorithmsTest() =
127107
runBlocking {
128108
listAlgs()
129-
println("Test 6 passed")
109+
logger.info("Test 6 passed")
130110
}
131111

132112
@Test
133113
@Order(7)
134114
fun listTrainingJobsTest() =
135115
runBlocking {
136116
listJobs()
137-
println("Test 7 passed")
117+
logger.info("Test 7 passed")
138118
}
139119

140120
@Test
141121
@Order(8)
142122
fun deleteModelTest() =
143123
runBlocking {
144124
deleteSagemakerModel(modelName)
145-
println("Test 8 passed")
125+
logger.info("Test 8 passed")
146126
}
147127

148128
private suspend fun getSecretValues(): String {
@@ -154,7 +134,6 @@ class SageMakerTest {
154134

155135
SecretsManagerClient {
156136
region = "us-east-1"
157-
credentialsProvider = EnvironmentCredentialsProvider()
158137
}.use { secretClient ->
159138
val valueResponse = secretClient.getSecretValue(valueRequest)
160139
return valueResponse.secretString.toString()
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<configuration>
2+
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
3+
<encoder>
4+
<pattern>%d{yyyy-MM-dd HH:mm:ss} [%thread] %-5level %logger{36} - %msg%n</pattern>
5+
</encoder>
6+
</appender>
7+
8+
<root level="info">
9+
<appender-ref ref="STDOUT"/>
10+
</root>
11+
</configuration>

0 commit comments

Comments
 (0)