Skip to content

Commit 8b6f85f

Browse files
scmacdonscmacdon
committed
rolled in review comments
1 parent 08b6a81 commit 8b6f85f

File tree

9 files changed

+72
-29
lines changed

9 files changed

+72
-29
lines changed

‎javav2/example_code/dynamodbasync/pom.xml‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,24 +39,28 @@
3939
<type>pom</type>
4040
<scope>import</scope>
4141
</dependency>
42+
<dependency>
43+
<groupId>org.junit</groupId>
44+
<artifactId>junit-bom</artifactId>
45+
<version>5.9.2</version>
46+
<type>pom</type>
47+
<scope>import</scope>
48+
</dependency>
4249
</dependencies>
4350
</dependencyManagement>
4451
<dependencies>
4552
<dependency>
4653
<groupId>software.amazon.awssdk</groupId>
4754
<artifactId>dynamodb-enhanced</artifactId>
48-
<version>2.11.4-PREVIEW</version>
4955
</dependency>
5056
<dependency>
5157
<groupId>org.junit.jupiter</groupId>
5258
<artifactId>junit-jupiter-api</artifactId>
53-
<version>5.4.2</version>
5459
<scope>test</scope>
5560
</dependency>
5661
<dependency>
5762
<groupId>org.junit.jupiter</groupId>
5863
<artifactId>junit-jupiter-engine</artifactId>
59-
<version>5.4.2</version>
6064
<scope>test</scope>
6165
</dependency>
6266
<dependency>

‎javav2/example_code/ec2/pom.xml‎

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,19 @@
4949
<type>pom</type>
5050
<scope>import</scope>
5151
</dependency>
52+
<dependency>
53+
<groupId>org.junit</groupId>
54+
<artifactId>junit-bom</artifactId>
55+
<version>5.9.2</version>
56+
<type>pom</type>
57+
<scope>import</scope>
58+
</dependency>
5259
</dependencies>
5360
</dependencyManagement>
5461
<dependencies>
5562
<dependency>
5663
<groupId>org.junit.jupiter</groupId>
5764
<artifactId>junit-jupiter-api</artifactId>
58-
<version>5.9.2</version>
5965
<scope>test</scope>
6066
</dependency>
6167
<dependency>
@@ -86,7 +92,6 @@
8692
<dependency>
8793
<groupId>org.junit.jupiter</groupId>
8894
<artifactId>junit-jupiter-engine</artifactId>
89-
<version>5.9.2</version>
9095
<scope>test</scope>
9196
</dependency>
9297
<dependency>
@@ -121,13 +126,5 @@
121126
<groupId>software.amazon.awssdk</groupId>
122127
<artifactId>ssm</artifactId>
123128
</dependency>
124-
<dependency>
125-
<groupId>software.amazon.awssdk</groupId>
126-
<artifactId>sso</artifactId>
127-
</dependency>
128-
<dependency>
129-
<groupId>software.amazon.awssdk</groupId>
130-
<artifactId>ssooidc</artifactId>
131-
</dependency>
132129
</dependencies>
133130
</project>

‎javav2/example_code/ecr/pom.xml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,13 @@
4444
<type>pom</type>
4545
<scope>import</scope>
4646
</dependency>
47+
<dependency>
48+
<groupId>org.junit</groupId>
49+
<artifactId>junit-bom</artifactId>
50+
<version>5.9.2</version>
51+
<type>pom</type>
52+
<scope>import</scope>
53+
</dependency>
4754
<dependency>
4855
<groupId>org.apache.logging.log4j</groupId>
4956
<artifactId>log4j-bom</artifactId>
@@ -57,7 +64,6 @@
5764
<dependency>
5865
<groupId>org.junit.jupiter</groupId>
5966
<artifactId>junit-jupiter-api</artifactId>
60-
<version>5.9.2</version>
6167
<scope>test</scope>
6268
</dependency>
6369
<dependency>
@@ -67,7 +73,6 @@
6773
<dependency>
6874
<groupId>org.junit.jupiter</groupId>
6975
<artifactId>junit-jupiter-engine</artifactId>
70-
<version>5.9.2</version>
7176
<scope>test</scope>
7277
</dependency>
7378
<dependency>

‎javav2/example_code/ecs/pom.xml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,24 @@
2121
<type>pom</type>
2222
<scope>import</scope>
2323
</dependency>
24+
<dependency>
25+
<groupId>org.junit</groupId>
26+
<artifactId>junit-bom</artifactId>
27+
<version>5.9.2</version>
28+
<type>pom</type>
29+
<scope>import</scope>
30+
</dependency>
2431
</dependencies>
2532
</dependencyManagement>
2633
<dependencies>
2734
<dependency>
2835
<groupId>org.junit.jupiter</groupId>
2936
<artifactId>junit-jupiter-api</artifactId>
30-
<version>5.9.2</version>
3137
<scope>test</scope>
3238
</dependency>
3339
<dependency>
3440
<groupId>org.junit.jupiter</groupId>
3541
<artifactId>junit-jupiter-engine</artifactId>
36-
<version>5.9.2</version>
3742
<scope>test</scope>
3843
</dependency>
3944
<dependency>

‎javav2/example_code/elasticbeanstalk/pom.xml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,19 @@
4343
<type>pom</type>
4444
<scope>import</scope>
4545
</dependency>
46+
<dependency>
47+
<groupId>org.junit</groupId>
48+
<artifactId>junit-bom</artifactId>
49+
<version>5.9.2</version>
50+
<type>pom</type>
51+
<scope>import</scope>
52+
</dependency>
4653
</dependencies>
4754
</dependencyManagement>
4855
<dependencies>
4956
<dependency>
5057
<groupId>org.junit.jupiter</groupId>
5158
<artifactId>junit-jupiter-api</artifactId>
52-
<version>5.9.2</version>
5359
<scope>test</scope>
5460
</dependency>
5561
<dependency>
@@ -68,7 +74,6 @@
6874
<dependency>
6975
<groupId>org.junit.jupiter</groupId>
7076
<artifactId>junit-jupiter-engine</artifactId>
71-
<version>5.9.2</version>
7277
<scope>test</scope>
7378
</dependency>
7479
<dependency>

‎javav2/example_code/emr/pom.xml‎

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,26 +40,31 @@
4040
<artifactId>bom</artifactId>
4141
<version>2.29.45</version>
4242
<type>pom</type>
43+
<scope>import</scope>
44+
</dependency>
45+
<dependency>
46+
<groupId>org.junit</groupId>
47+
<artifactId>junit-bom</artifactId>
48+
<version>5.9.2</version>
49+
<type>pom</type>
50+
<scope>import</scope>
4351
</dependency>
4452
</dependencies>
4553
</dependencyManagement>
4654
<dependencies>
4755
<dependency>
4856
<groupId>org.junit.jupiter</groupId>
4957
<artifactId>junit-jupiter-api</artifactId>
50-
<version>5.9.2</version>
5158
<scope>test</scope>
5259
</dependency>
5360
<dependency>
5461
<groupId>org.junit.jupiter</groupId>
5562
<artifactId>junit-jupiter-engine</artifactId>
56-
<version>5.9.2</version>
5763
<scope>test</scope>
5864
</dependency>
5965
<dependency>
6066
<groupId>software.amazon.awssdk</groupId>
6167
<artifactId>secretsmanager</artifactId>
62-
<version>2.29.45</version>
6368
</dependency>
6469
<dependency>
6570
<groupId>com.google.code.gson</groupId>
@@ -85,7 +90,14 @@
8590
<dependency>
8691
<groupId>software.amazon.awssdk</groupId>
8792
<artifactId>emr</artifactId>
88-
<version>2.29.45</version>
93+
</dependency>
94+
<dependency>
95+
<groupId>software.amazon.awssdk</groupId>
96+
<artifactId>sso</artifactId>
97+
</dependency>
98+
<dependency>
99+
<groupId>software.amazon.awssdk</groupId>
100+
<artifactId>ssooidc</artifactId>
89101
</dependency>
90102
</dependencies>
91103
</project>

‎javav2/example_code/eventbridge/pom.xml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,19 @@
3333
<type>pom</type>
3434
<scope>import</scope>
3535
</dependency>
36+
<dependency>
37+
<groupId>org.junit</groupId>
38+
<artifactId>junit-bom</artifactId>
39+
<version>5.9.2</version>
40+
<type>pom</type>
41+
<scope>import</scope>
42+
</dependency>
3643
</dependencies>
3744
</dependencyManagement>
3845
<dependencies>
3946
<dependency>
4047
<groupId>org.junit.jupiter</groupId>
4148
<artifactId>junit-jupiter-api</artifactId>
42-
<version>5.9.0</version>
4349
<scope>test</scope>
4450
</dependency>
4551
<dependency>
@@ -54,7 +60,6 @@
5460
<dependency>
5561
<groupId>org.junit.jupiter</groupId>
5662
<artifactId>junit-jupiter-engine</artifactId>
57-
<version>5.9.0</version>
5863
<scope>test</scope>
5964
</dependency>
6065
<dependency>

‎javav2/example_code/firehose/pom.xml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,19 @@
4242
<type>pom</type>
4343
<scope>import</scope>
4444
</dependency>
45+
<dependency>
46+
<groupId>org.junit</groupId>
47+
<artifactId>junit-bom</artifactId>
48+
<version>5.9.2</version>
49+
<type>pom</type>
50+
<scope>import</scope>
51+
</dependency>
4552
</dependencies>
4653
</dependencyManagement>
4754
<dependencies>
4855
<dependency>
4956
<groupId>org.junit.jupiter</groupId>
5057
<artifactId>junit-jupiter-api</artifactId>
51-
<version>5.9.2</version>
5258
<scope>test</scope>
5359
</dependency>
5460
<dependency>
@@ -67,7 +73,6 @@
6773
<dependency>
6874
<groupId>org.junit.jupiter</groupId>
6975
<artifactId>junit-jupiter-engine</artifactId>
70-
<version>5.9.2</version>
7176
<scope>test</scope>
7277
</dependency>
7378
<dependency>

‎javav2/example_code/forecast/pom.xml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,24 @@
3333
<type>pom</type>
3434
<scope>import</scope>
3535
</dependency>
36+
<dependency>
37+
<groupId>org.junit</groupId>
38+
<artifactId>junit-bom</artifactId>
39+
<version>5.9.2</version>
40+
<type>pom</type>
41+
<scope>import</scope>
42+
</dependency>
3643
</dependencies>
3744
</dependencyManagement>
3845
<dependencies>
3946
<dependency>
4047
<groupId>org.junit.jupiter</groupId>
4148
<artifactId>junit-jupiter-api</artifactId>
42-
<version>5.9.2</version>
4349
<scope>test</scope>
4450
</dependency>
4551
<dependency>
4652
<groupId>org.junit.jupiter</groupId>
4753
<artifactId>junit-jupiter-engine</artifactId>
48-
<version>5.9.2</version>
4954
<scope>test</scope>
5055
</dependency>
5156
<dependency>

0 commit comments

Comments
 (0)