Skip to content

Commit 98fbb08

Browse files
author
Tejas Ganesh Naik
committed
added necessary testing annotations and added periods on comments
1 parent 084a6c2 commit 98fbb08

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

javav2/example_code/sqs/src/main/java/com/example/sqs/SendRecvBatch.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ public static void usageDemo() {
220220
System.out.println("Welcome to the Amazon Simple Queue Service (Amazon SQS) demo!");
221221
System.out.println("-".repeat(88));
222222

223-
// Create a queue for the demo
223+
// Create a queue for the demo.
224224
String queueName = "sqs-usage-demo-message-wrapper-"+System.currentTimeMillis();
225225
CreateQueueRequest createRequest = CreateQueueRequest.builder()
226226
.queueName(queueName)
@@ -229,13 +229,13 @@ public static void usageDemo() {
229229
System.out.println("Created queue: " + queueUrl);
230230

231231
try {
232-
// Read the lines from this Java file
232+
// Read the lines from this Java file.
233233
Path projectRoot = Paths.get(System.getProperty("user.dir"));
234234
Path filePath = projectRoot.resolve("src/main/java/com/example/sqs/SendRecvBatch.java");
235235
List<String> lines = Files.readAllLines(filePath);
236236

237237

238-
// Send file lines in batches
238+
// Send file lines in batches.
239239
int batchSize = 10;
240240
System.out.println("Sending file lines in batches of " + batchSize + " as messages.");
241241

@@ -245,7 +245,7 @@ public static void usageDemo() {
245245
for (int j = i; j < Math.min(i + batchSize, lines.size()); j++) {
246246
String line = lines.get(j);
247247
if (line == null || line.trim().isEmpty()) {
248-
continue; // Skip empty lines
248+
continue; // Skip empty lines.
249249
}
250250

251251
Map<String, MessageAttributeValue> attributes = new HashMap<>();
@@ -268,7 +268,7 @@ public static void usageDemo() {
268268

269269
System.out.println("\nDone. Sent " + lines.size() + " messages.");
270270

271-
// Receive and process messages
271+
// Receive and process messages.
272272
System.out.println("Receiving, handling, and deleting messages in batches of " + batchSize + ".");
273273
String[] receivedLines = new String[lines.size()];
274274
boolean moreMessages = true;
@@ -292,7 +292,7 @@ public static void usageDemo() {
292292

293293
System.out.println("\nDone.");
294294

295-
// Verify all lines were received correctly
295+
// Verify all lines were received correctly.
296296
boolean allLinesMatch = true;
297297
for (int i = 0; i < lines.size(); i++) {
298298
String originalLine = lines.get(i);
@@ -313,7 +313,7 @@ public static void usageDemo() {
313313
} catch (IOException e) {
314314
logger.log(Level.SEVERE, "Error reading file", e);
315315
} finally {
316-
// Clean up by deleting the queue
316+
// Clean up by deleting the queue.
317317
DeleteQueueRequest deleteQueueRequest = DeleteQueueRequest.builder()
318318
.queueUrl(queueUrl)
319319
.build();

javav2/example_code/sqs/src/test/java/com/example/sqs/SendRecvBatchTest.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,13 @@
1818
import java.util.stream.Stream;
1919

2020
import static org.junit.jupiter.api.Assertions.*;
21+
import org.junit.jupiter.api.TestInstance;
22+
import org.junit.jupiter.api.TestMethodOrder;
23+
import org.junit.jupiter.api.MethodOrderer;
24+
import org.junit.jupiter.api.Order;
2125

26+
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
27+
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
2228
public class SendRecvBatchTest {
2329
private static final Logger logger = LoggerFactory.getLogger(SendRecvBatchTest.class);
2430
private static final SqsClient sqsClient = SqsClient.create();
@@ -56,6 +62,7 @@ private static Stream<Arguments> sendMessageBatchTestData() {
5662

5763
@ParameterizedTest
5864
@MethodSource("sendMessageBatchTestData")
65+
@Order(1)
5966
void testSendMessages(List<SendRecvBatch.MessageEntry> messages) {
6067
logger.info("Testing send messages with {} messages", messages.size());
6168
SendMessageBatchResponse response = SendRecvBatch.sendMessages(queueUrl, messages);
@@ -64,6 +71,7 @@ void testSendMessages(List<SendRecvBatch.MessageEntry> messages) {
6471
}
6572

6673
@Test
74+
@Order(2)
6775
void testReceiveMessages() {
6876
logger.info("Testing receive messages");
6977
// First send some messages
@@ -80,6 +88,7 @@ void testReceiveMessages() {
8088
}
8189

8290
@Test
91+
@Order(3)
8392
void testDeleteMessages() {
8493
logger.info("Testing delete messages");
8594
// First send and receive messages
@@ -99,6 +108,7 @@ void testDeleteMessages() {
99108
}
100109

101110
@Test
111+
@Order(4)
102112
void testMessageEntry() {
103113
logger.info("Testing MessageEntry with attributes");
104114
Map<String, MessageAttributeValue> attributes = Map.of(
@@ -116,6 +126,7 @@ void testMessageEntry() {
116126
}
117127

118128
@Test
129+
@Order(5)
119130
void testMessageEntryWithNullAttributes() {
120131
logger.info("Testing MessageEntry with null attributes");
121132
SendRecvBatch.MessageEntry entry = new SendRecvBatch.MessageEntry("Test body", null);

0 commit comments

Comments
 (0)