rubocop fixes

Author: ford-at-aws

.github/linters/.ruby-lint.yml

@@ -1,21 +1,106 @@
----
 #######################
 # Rubocop Config file #
 #######################
+
 Metrics/MethodLength:
   Max: 25
+  Exclude:
+    - alarm_actions.rb
+    - alarm_basics.rb
+    - create_alarm.rb
+    - metrics_basics.rb
+    - show_alarms.rb
+    - scenario_users.rb
+    - auth_session_token_request_test.rb
+
 Metrics/BlockLength:
   Max: 75
+  Exclude:
+    - spec/send_events_ec2_spec.rb
+    - encryption_v2/spec/test_s3_get_cskms_decrypt_item.rb
+
 Metrics/AbcSize:
   Max: 20
+  Exclude:
+    - metrics_basics.rb
+    - show_alarms.rb
+    - list_users.rb
+    - manage_users.rb
+    - scenario_users.rb
+    - auth_session_token_request_test.rb
+    - encryption_v2/spec/test_s3_get_cskms_decrypt_item.rb
+
+Metrics/ParameterLists:
+  Max: 5
+  Exclude:
+    - alarm_actions.rb
+    - alarm_basics.rb
+    - create_alarm.rb
+    - metrics_basics.rb
+
+Metrics/CyclomaticComplexity:
+  Max: 7
+  Exclude:
+    - show_alarms.rb
+
+Metrics/PerceivedComplexity:
+  Max: 8
+  Exclude:
+    - show_alarms.rb
+    - auth_session_token_request_test.rb
+
+Metrics/ClassLength:
+  Max: 100
+  Exclude:
+    - manage_roles.rb
+    - manage_users.rb
+    - scenario_users.rb
+
 Style/FrozenStringLiteralComment:
   Enabled: false
+
 Layout/EndOfLine:
   Enabled: false
+
 Layout/LineLength:
+  Max: 120
   Exclude:
     - ruby/example_code/kms/decrypt_data.rb
+    - spec/list_admins_spec.rb
+    - encryption_v2/s3_add_cskms_encrypt_item.rb
+    - encryption_v2/spec/test_s3_add_cskms_encrypt_item.rb
+    - encryption_v2/spec/test_s3_get_cskms_decrypt_item.rb
+
 Naming/FileName:
   Enabled: false
+
 Style/HashSyntax:
   EnforcedShorthandSyntax: either
+
+Naming/PredicateName:
+  Enabled: false
+  Exclude:
+    - list_admins.rb
+
+Naming/AccessorMethodName:
+  Enabled: false
+  Exclude:
+    - list_users.rb
+    - manage_users.rb
+    - bucket_cors.rb
+    - bucket_policy.rb
+    - bucket_put_encryption.rb
+    - encryption_v2/s3_add_csaes_encrypt_item.rb
+    - object_get_encryption.rb
+    - s3.rb
+
+Naming/MethodParameterName:
+  Min: 3
+  Exclude:
+    - manage_roles.rb
+    - s3.rb
+
+Naming/VariableNumber:
+  Enabled: false
+  Exclude:
+    - encryption_v2/s3_add_csaes_encrypt_item.rb

ruby/example_code/cloudwatch/alarm_actions.rb

@@ -6,7 +6,7 @@
 # 2. Disable all actions for an alarm.
 
 # snippet-start:[cloudwatch.Ruby.createAnAlarm]
-require "aws-sdk-cloudwatch"
+require 'aws-sdk-cloudwatch'
 
 # Creates or updates an alarm in Amazon CloudWatch.
 
@@ -84,11 +84,12 @@ def alarm_created_or_updated?(
     threshold: threshold,
     comparison_operator: comparison_operator
   )
-  return true
+  true
 rescue StandardError => e
   puts "Error creating alarm: #{e.message}"
-  return false
+  false
 end
+
 # snippet-end:[cloudwatch.Ruby.createAnAlarm]
 # snippet-start:[cloudwatch.Ruby.disableAnAlarm]
 # Disables an alarm in Amazon CloudWatch.
@@ -108,39 +109,39 @@ def alarm_created_or_updated?(
 #   )
 def alarm_actions_disabled?(cloudwatch_client, alarm_name)
   cloudwatch_client.disable_alarm_actions(alarm_names: [alarm_name])
-  return true
+  true
 rescue StandardError => e
   puts "Error disabling alarm actions: #{e.message}"
-  return false
+  false
 end
 
 # Example usage:
 def run_me
-  alarm_name = "ObjectsInBucket"
-  alarm_description = "Objects exist in this bucket for more than 1 day."
-  metric_name = "NumberOfObjects"
+  alarm_name = 'ObjectsInBucket'
+  alarm_description = 'Objects exist in this bucket for more than 1 day.'
+  metric_name = 'NumberOfObjects'
   # Notify this Amazon Simple Notification Service (Amazon SNS) topic when
   # the alarm transitions to the ALARM state.
-  alarm_actions = ["arn:aws:sns:us-east-1:111111111111:Default_CloudWatch_Alarms_Topic"]
-  namespace = "AWS/S3"
-  statistic = "Average"
+  alarm_actions = ['arn:aws:sns:us-east-1:111111111111:Default_CloudWatch_Alarms_Topic']
+  namespace = 'AWS/S3'
+  statistic = 'Average'
   dimensions = [
     {
-      name: "BucketName",
-      value: "amzn-s3-demo-doc-example-bucket"
+      name: 'BucketName',
+      value: 'amzn-s3-demo-doc-example-bucket'
     },
     {
-      name: "StorageType",
-      value: "AllStorageTypes"
+      name: 'StorageType',
+      value: 'AllStorageTypes'
     }
   ]
   period = 86_400 # Daily (24 hours * 60 minutes * 60 seconds = 86400 seconds).
-  unit = "Count"
+  unit = 'Count'
   evaluation_periods = 1 # More than one day.
   threshold = 1 # One object.
-  comparison_operator = "GreaterThanThreshold" # More than one object.
+  comparison_operator = 'GreaterThanThreshold' # More than one object.
   # Replace us-west-2 with the AWS Region you're using for Amazon CloudWatch.
-  region = "us-east-1"
+  region = 'us-east-1'
 
   cloudwatch_client = Aws::CloudWatch::Client.new(region: region)
 

ruby/example_code/cloudwatch/alarm_basics.rb

@@ -6,7 +6,7 @@
 # 2. Create or update an alarm.
 # 3. Delete an alarm.
 # snippet-start:[cloudwatch.Ruby.getAlarmList]
-require "aws-sdk-cloudwatch"
+require 'aws-sdk-cloudwatch'
 
 # Lists the names of available Amazon CloudWatch alarms.
 #
@@ -21,11 +21,12 @@ def list_alarms(cloudwatch_client)
       puts alarm.alarm_name
     end
   else
-    puts "No alarms found."
+    puts 'No alarms found.'
   end
 rescue StandardError => e
   puts "Error getting information about alarms: #{e.message}"
 end
+
 # snippet-end:[cloudwatch.Ruby.getAlarmList]
 # snippet-start:[cloudwatch.Ruby.PutMetricAlarm]
 # Creates or updates an alarm in Amazon CloudWatch.
@@ -104,11 +105,12 @@ def alarm_created_or_updated?(
     threshold: threshold,
     comparison_operator: comparison_operator
   )
-  return true
+  true
 rescue StandardError => e
   puts "Error creating alarm: #{e.message}"
-  return false
+  false
 end
+
 # snippet-end:[cloudwatch.Ruby.PutMetricAlarm]
 # snippet-start:[cloudwatch.Ruby.deleteAlarm]
 # Deletes an alarm in Amazon CloudWatch.
@@ -128,43 +130,43 @@ def alarm_created_or_updated?(
 #   )
 def alarm_deleted?(cloudwatch_client, alarm_name)
   cloudwatch_client.delete_alarms(alarm_names: [alarm_name])
-  return true
+  true
 rescue StandardError => e
   puts "Error deleting alarm: #{e.message}"
-  return false
+  false
 end
 
 # Example usage:
 def run_me
-  alarm_name = "ObjectsInBucket"
-  alarm_description = "Objects exist in this bucket for more than 1 day."
-  metric_name = "NumberOfObjects"
+  alarm_name = 'ObjectsInBucket'
+  alarm_description = 'Objects exist in this bucket for more than 1 day.'
+  metric_name = 'NumberOfObjects'
   # Notify this Amazon Simple Notification Service (Amazon SNS) topic when
   # the alarm transitions to the ALARM state.
-  alarm_actions = ["arn:aws:sns:us-east-1:111111111111:Default_CloudWatch_Alarms_Topic"]
-  namespace = "AWS/S3"
-  statistic = "Average"
+  alarm_actions = ['arn:aws:sns:us-east-1:111111111111:Default_CloudWatch_Alarms_Topic']
+  namespace = 'AWS/S3'
+  statistic = 'Average'
   dimensions = [
     {
-      name: "BucketName",
-      value: "amzn-s3-demo-doc-example-bucket"
+      name: 'BucketName',
+      value: 'amzn-s3-demo-doc-example-bucket'
     },
     {
-      name: "StorageType",
-      value: "AllStorageTypes"
+      name: 'StorageType',
+      value: 'AllStorageTypes'
     }
   ]
   period = 86_400 # Daily (24 hours * 60 minutes * 60 seconds = 86400 seconds).
-  unit = "Count"
+  unit = 'Count'
   evaluation_periods = 1 # More than one day.
   threshold = 1 # One object.
-  comparison_operator = "GreaterThanThreshold" # More than one object.
+  comparison_operator = 'GreaterThanThreshold' # More than one object.
   # Replace us-west-2 with the AWS Region you're using for Amazon CloudWatch.
-  region = "us-east-1"
+  region = 'us-east-1'
 
   cloudwatch_client = Aws::CloudWatch::Client.new(region: region)
 
-  puts "Available Amazon CloudWatch alarms:"
+  puts 'Available Amazon CloudWatch alarms:'
   list_alarms(cloudwatch_client)
 
   if alarm_created_or_updated?(

ruby/example_code/cloudwatch/create_alarm.rb

@@ -5,7 +5,7 @@
 
 # snippet-start:[cloudwatch.Ruby.createAlarm]
 
-require "aws-sdk-cloudwatch"
+require 'aws-sdk-cloudwatch'
 
 # @param cloudwatch_client [Aws::CloudWatch::Client]
 #   An initialized CloudWatch client.
@@ -81,39 +81,39 @@ def alarm_created_or_updated?(
     threshold: threshold,
     comparison_operator: comparison_operator
   )
-  return true
+  true
 rescue StandardError => e
   puts "Error creating alarm: #{e.message}"
-  return false
+  false
 end
 
 # Example usage:
 def run_me
-  alarm_name = "ObjectsInBucket"
-  alarm_description = "Objects exist in this bucket for more than 1 day."
-  metric_name = "NumberOfObjects"
+  alarm_name = 'ObjectsInBucket'
+  alarm_description = 'Objects exist in this bucket for more than 1 day.'
+  metric_name = 'NumberOfObjects'
   # Notify this Amazon Simple Notification Service (Amazon SNS) topic when
   # the alarm transitions to the ALARM state.
-  alarm_actions = ["arn:aws:sns:us-east-1:111111111111:Default_CloudWatch_Alarms_Topic"]
-  namespace = "AWS/S3"
-  statistic = "Average"
+  alarm_actions = ['arn:aws:sns:us-east-1:111111111111:Default_CloudWatch_Alarms_Topic']
+  namespace = 'AWS/S3'
+  statistic = 'Average'
   dimensions = [
     {
-      name: "BucketName",
-      value: "amzn-s3-demo-doc-example-bucket"
+      name: 'BucketName',
+      value: 'amzn-s3-demo-doc-example-bucket'
     },
     {
-      name: "StorageType",
-      value: "AllStorageTypes"
+      name: 'StorageType',
+      value: 'AllStorageTypes'
     }
   ]
   period = 86_400 # Daily (24 hours * 60 minutes * 60 seconds = 86400 seconds).
-  unit = "Count"
+  unit = 'Count'
   evaluation_periods = 1 # More than one day.
   threshold = 1 # One object.
-  comparison_operator = "GreaterThanThreshold" # More than one object.
+  comparison_operator = 'GreaterThanThreshold' # More than one object.
   # Replace us-west-2 with the AWS Region you're using for Amazon CloudWatch.
-  region = "us-east-1"
+  region = 'us-east-1'
 
   cloudwatch_client = Aws::CloudWatch::Client.new(region: region)