Skip to content

Commit ab6a7d9

Browse files
committed
Normalize adding (and allowing missing) trailing newlines for READMEs.
1 parent 74733d2 commit ab6a7d9

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

.tools/readmes/render.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,7 @@ def render(self) -> RenderStatus:
304304
customs=customs,
305305
unsupported=unsupported,
306306
)
307+
self.readme_text += "\n" # Jinja is the worst and strips trailing new lines
307308
[text, errors] = expand_all_entities(self.readme_text, self.scanner.doc_gen.entities)
308309
if errors:
309310
raise errors

.tools/readmes/runner.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,12 @@ def main():
173173

174174
def make_diff(renderer, id):
175175
current = renderer.read_current().split("\n")
176+
if current[-1] != "":
177+
# Ensure final "last" line
178+
current += [""]
176179
expected = renderer.readme_text.split("\n")
180+
if expected[-1] != "":
181+
# Ensure final "last" line
182+
expected += [""]
177183
diff = unified_diff(current, expected, f"{id}/current", f"{id}/expected")
178184
return "\n".join(diff)

0 commit comments

Comments
 (0)