Skip to content

Commit b95ed11

Browse files
committed
Document resource types.
1 parent 37f1b53 commit b95ed11

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

.tools/test/stacks/config/targets.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@ import { parse } from "yaml";
77
interface AccountConfig {
88
account_id: string;
99
status: "enabled" | "disabled";
10-
vcpus?: string;
11-
memory?: string;
12-
storage?: string;
10+
// https://docs.aws.amazon.com/batch/latest/APIReference/API_ResourceRequirement.html
11+
vcpus?: string; // Count
12+
memory?: string; // MiB, but limited based on vCPU count, see docs
13+
storage?: string; // GiB, 20GiB to 200GiB
1314
}
1415

1516
interface AccountConfigs {

.tools/test/stacks/plugin/typescript/plugin_stack.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,10 @@ class PluginStack extends cdk.Stack {
4141
const sqsQueue = new sqs.Queue(this, `BatchJobQueue-${toolName}`);
4242
if (acctConfig[`${toolName}`].status === "enabled") {
4343
this.initSubscribeSns(sqsQueue, snsTopic);
44-
this.batchMemory = acctConfig[`${toolName}`]?.memory ?? "16384";
45-
this.batchVcpus = acctConfig[`${toolName}`]?.vcpus ?? "4";
46-
this.batchStorage = acctConfig[`${toolName}`]?.storage ?? "20";
44+
// https://docs.aws.amazon.com/batch/latest/APIReference/API_ResourceRequirement.html
45+
this.batchMemory = acctConfig[`${toolName}`]?.memory ?? "16384"; // MiB
46+
this.batchVcpus = acctConfig[`${toolName}`]?.vcpus ?? "4"; // CPUs
47+
this.batchStorage = acctConfig[`${toolName}`]?.storage ?? "20"; // GiB
4748
}
4849

4950
const [jobDefinition, jobQueue] = this.initBatchFargate();

0 commit comments

Comments
 (0)