Skip to content

Commit ba2dea7

Browse files
authored
Update method name to describe a Get request (#7558)
Fix for https://t.corp.amazon.com/V1905732087
1 parent 2bd647a commit ba2dea7

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

javav2/example_code/s3/src/main/java/com/example/s3/GeneratePresignedGetUrlAndRetrieve.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public static void main(String[] args) {
6060
String presignedUrlString = presign.createPresignedGetUrl(bucketName, keyName);
6161
presign.useHttpUrlConnectionToGet(presignedUrlString);
6262
presign.useHttpClientToGet(presignedUrlString);
63-
presign.useSdkHttpClientToPut(presignedUrlString);
63+
presign.useSdkHttpClientToGet(presignedUrlString);
6464
} finally {
6565
PresignUrlUtils.deleteObject(bucketName, keyName, s3Client);
6666
PresignUrlUtils.deleteBucket(bucketName, s3Client);
@@ -142,7 +142,7 @@ public byte[] useHttpClientToGet(String presignedUrlString) {
142142

143143
// snippet-start:[presigned.java2.generatepresignedgeturlandretrieve.sdkhttpclient]
144144
/* Use the AWS SDK for Java SdkHttpClient class to do the download. */
145-
public byte[] useSdkHttpClientToPut(String presignedUrlString) {
145+
public byte[] useSdkHttpClientToGet(String presignedUrlString) {
146146

147147
ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream(); // Capture the response body to a byte array.
148148
try {

javav2/example_code/s3/src/test/java/com/example/s3/presignurl/GeneratePresignedGetUrlTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ void testUsingJdkHttpClient() {
7070
GeneratePresignedGetUrlAndRetrieve presignInstanceUnderTest = new GeneratePresignedGetUrlAndRetrieve();
7171
final String presignedUrlString = presignInstanceUnderTest.createPresignedGetUrl(BUCKET_NAME, KEY_NAME);
7272

73-
final byte[] bytes = presignInstanceUnderTest.useSdkHttpClientToPut(presignedUrlString);
73+
final byte[] bytes = presignInstanceUnderTest.useSdkHttpClientToGet(presignedUrlString);
7474
Assertions.assertTrue(bytes.length > 0);
7575
}
7676
}

0 commit comments

Comments
 (0)