C++,Bash: Multi-service, update bucket names. #6944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyertst-aws
added
C++
scmacdon
reviewed
Sep 30, 2024
scmacdon
approved these changes
Sep 30, 2024
Fix DynamoDB tests to wait for active Fixed bash scenario.
meyertst-aws
force-pushed
the
6903-update-bucket-names-in-all-c++-examples-to-confirm-with-guidelines
branch
from
7415f65 to
57c4275
Compare
meyertst-aws
changed the title
rlhagerm
added
On Call Review complete
meyertst-aws
deleted the
6903-update-bucket-names-in-all-c++-examples-to-confirm-with-guidelines
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds user input to replace "amzn-s3-demo-bucket" for bucket names.
It adds waiters to DynamoDB code to fix some testing issues.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.