Skip to content

Conversation

@shepazon
Copy link
Contributor

@shepazon shepazon commented Oct 1, 2024

This PR includes minor changes to the Buckets sample for Swift, including comment updates and the addition of a guard statement to protect against unpredictable results when calling the getBucketList() function without an identity resolver.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@shepazon shepazon self-assigned this Oct 1, 2024
@shepazon shepazon added the Swift This issue relates to the AWS SDK for Swift label Oct 1, 2024
@shepazon shepazon requested a review from meyertst-aws October 1, 2024 20:02
Copy link
Contributor

@meyertst-aws meyertst-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shepazon shepazon added the On Call Review needed This work needs an on-call review label Oct 2, 2024
@rlhagerm rlhagerm added On Call Review complete On call review complete Bug An update to fix incorrect code or typos. and removed On Call Review needed This work needs an on-call review labels Oct 2, 2024
@rlhagerm rlhagerm merged commit fae5994 into awsdocs:main Oct 2, 2024
14 checks passed
@shepazon shepazon deleted the buckets-tweaks branch September 9, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug An update to fix incorrect code or typos. On Call Review complete On call review complete Swift This issue relates to the AWS SDK for Swift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants