Skip to content

Conversation

@tkhill-AWS
Copy link
Collaborator

This pull request updates a C++ S3 PutObjectAsync example by creating a request object in the main method to ensure it exists through all async calls.

Fix for https://taskei.amazon.dev/tasks/V1888980758

This example is used only in the C++ Dev. guide, not in the Code Examples library.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the C++ This issue relates to the AWS SDK for C++ label Aug 30, 2025
@rlhagerm rlhagerm requested review from a team and tejasgn1 and removed request for a team September 2, 2025 14:28
@rlhagerm rlhagerm added the Task A general update to the code base for language clarification, missing actions, tests, etc. label Sep 2, 2025
Copy link
Contributor

@tejasgn1 tejasgn1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. There were no build issues with S3 PutObjectAsync example code and the test for it also ran without any error.

@tejasgn1 tejasgn1 added the On Call Review needed This work needs an on-call review label Sep 9, 2025
@beqqrry-aws beqqrry-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Sep 10, 2025
@beqqrry-aws beqqrry-aws merged commit 1d0d3bc into awsdocs:main Sep 10, 2025
18 of 19 checks passed
@tkhill-AWS tkhill-AWS deleted the cpp-async-put-object branch September 11, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ This issue relates to the AWS SDK for C++ On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants