chore: drop shellcheck level to warning (#2371)

* update shellcheck presubmit to report warnings and above
* use shfmt's logic for finding shell files instead of my hacky script
* fix most existing warnings

Author: fletcherw

.github/actions/janitor/ami-sweeper/script.sh

@@ -12,8 +12,8 @@ fi
 set -o nounset
 
 # https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-retries.html
-AWS_RETRY_MODE=standard
-AWS_MAX_ATTEMPTS=5
+export AWS_RETRY_MODE=standard
+export AWS_MAX_ATTEMPTS=5
 
 function jqb64() {
   if [ "$#" -lt 2 ]; then

Makefile

@@ -63,7 +63,7 @@ lint: lint-docs lint-code
 .PHONY: lint-code
 lint-code: ## Check the source files for syntax and format issues
 	hack/shfmt --diff
-	hack/shellcheck --format gcc --severity error
+	hack/shellcheck --format gcc --severity warning
 	hack/lint-space-errors.sh
 
 .PHONY: test

hack/findshell.sh

@@ -11,12 +11,11 @@ if [ "$#" -ne 1 ]; then
   exit 1
 fi
 
-cd $(dirname $0)
+cd "$(dirname $0)"
 
 RUNFILE="${1}"
 RUNFILE_DIR=$(basename "${RUNFILE}" | sed s/\.run//g)
 TEMP_DIR=$(mktemp -d)
-DEVICE_FILE="devices.txt"
 SUPPORTED_GPUS_FILE="supported-gpus/supported-gpus.json"
 
 cp "${RUNFILE}" "${TEMP_DIR}"

hack/generate-nvidia-open-supported-devices.sh

@@ -2,7 +2,7 @@
 
 set -o errexit
 
-cd $(dirname $0)
+cd "$(dirname $0)"
 
 ./generate-template-variable-doc.py
 if ! git diff --exit-code ../doc/usage/; then

hack/lint-docs.sh

@@ -1,8 +1,10 @@
 #!/usr/bin/env bash
 
-cd $(dirname $0)/..
+set -o errexit
+
+cd "$(dirname $0)/.."
 
 # `git apply|diff` can check for space errors, with the core implementation being `git diff-tree`
 # this tool compares two trees, generally used to find errors in proposed changes
 # we want to check the entire existing tree, so we compare HEAD against an empty tree
-git diff-tree --check $(git hash-object -t tree /dev/null) HEAD ':!nodeadm/vendor/'
+git diff-tree --check "$(git hash-object -t tree /dev/null)" HEAD ':!nodeadm/vendor/'

hack/lint-space-errors.sh

@@ -2,7 +2,7 @@
 
 set -o errexit
 
-cd $(dirname $0)
+cd "$(dirname $0)"
 
 IMAGE_ID=$(docker build --file mkdocs.Dockerfile --quiet .)
 cd ..

hack/mkdocs.sh

@@ -1,6 +1,8 @@
 #!/usr/bin/env bash
 
-cd $(dirname $0)/../nodeadm
+set -o errexit
+
+cd "$(dirname $0)/../nodeadm"
 make generate
 if ! git diff --exit-code .; then
   echo "ERROR: nodeadm generated code is out of date. Please run make generate and commit the changes."

hack/nodeadm-check-generate.sh

@@ -4,11 +4,11 @@ set -o errexit
 set -o nounset
 set -o pipefail
 
-cd $(dirname $0)/../nodeadm
+cd "$(dirname $0)/../nodeadm"
 
 TEMP_DIR="$(mktemp -d)"
 go mod vendor -o "${TEMP_DIR}"
-if ! DIFF="$(diff -Naupr vendor ${TEMP_DIR})"; then
+if ! diff -Naupr vendor ${TEMP_DIR}; then
   echo "ERROR: the vendor directory is not up to date! You need to run 'go mod vendor' and commit the changes." >&2
   exit 1
 fi

hack/nodeadm-check-vendor.sh

@@ -4,9 +4,9 @@
 set -o nounset
 
 WORKDIR=$(realpath .)
-FILES=$(hack/findshell.sh ${WORKDIR})
+FILES=$(hack/shfmt_command.sh --find --language-dialect auto "${WORKDIR}" | grep -v "nodeadm/vendor/")
 SHELLCHECK_COMMAND=$(which shellcheck 2> /dev/null)
 if [ -z "$SHELLCHECK_COMMAND" ]; then
   SHELLCHECK_COMMAND="docker run --rm -v $WORKDIR:$WORKDIR -w $WORKDIR koalaman/shellcheck:stable"
 fi
-$SHELLCHECK_COMMAND $* $FILES
+$SHELLCHECK_COMMAND "$@" $FILES