Fix memory leak in kinesis_video_gstreamer_audio_video_sample_app

Author: chehefen

README.md

@@ -50,6 +50,9 @@ This library is licensed under the Amazon Software License.
 ----
 ### Release notes
 
+#### Release 1.7.9 (13th Mar 2019)
+* Fix memory leak in kinesis_video_gstreamer_audio_video_sample_app.
+
 #### Release 1.7.8 (6th Mar 2019)
 * Updated CMakeLists.txt and install scripts to be able to link against libraries in default system path.
 * Optimization and bug fixes.

docker_native_scripts/README.md

@@ -30,7 +30,7 @@ Download the `Dockerfile` and `start_rtsp_in_docker.sh` into a folder.  Once the
 
 *  Start the Kinesis Video Streams Docker container using the following command:
 ```
-   $ docker run -it <IMAGE_ID> <AWS_ACCESS_KEY_ID> <AWS_SECRET_ACCESS_KEY> <STREAM_NAME> <RTSP_URL>
+   $ docker run -it <IMAGE_ID> <AWS_ACCESS_KEY_ID> <AWS_SECRET_ACCESS_KEY> <RTSP_URL> <STREAM_NAME>
 ```
 
 

docker_native_scripts/start_rtsp_in_docker.sh

@@ -6,4 +6,6 @@ cd /opt/amazon-kinesis-video-streams-producer-sdk-cpp/kinesis-video-native-build
 
 # Start the demo rtsp application to send video streams
 export LD_LIBRARY_PATH=/opt/amazon-kinesis-video-streams-producer-sdk-cpp/kinesis-video-native-build/downloads/local/lib:$LD_LIBRARY_PATH
-AWS_ACCESS_KEY_ID=$1 AWS_SECRET_ACCESS_KEY=$2 ./kinesis_video_gstreamer_sample_app $3 $4
+
+# $3 for STREAM_NAME and $4 is RTSP_URL
+AWS_ACCESS_KEY_ID=$1 AWS_SECRET_ACCESS_KEY=$2 ./kinesis_video_gstreamer_sample_app $4 $3

docker_native_scripts/windows/start_rtsp_in_docker.bat

@@ -8,5 +8,5 @@ set PATH=%PATH%;C:\opt\amazon-kinesis-video-streams-producer-sdk-cpp\kinesis-vid
 set AWS_ACCESS_KEY_ID=%1
 set AWS_SECRET_ACCESS_KEY=%2
 
-REM %3 is RTSP_URL and %4 for STREAM_NAME
-kinesis_video_gstreamer_sample_app.exe %3 %4
+REM %3 for STREAM_NAME and %4 is RTSP_URL
+kinesis_video_gstreamer_sample_app.exe %4 %3

docker_native_scripts/windows/windows-docker-readme.md

@@ -28,5 +28,5 @@ Use the **IMAGE_ID** from the output (e.g `02181afc49f9`):
 #### 3. Start the Docker container to run RTSP video streaming
 Run the Docker container to send video to Kinesis Video Streams using the following command:
 ```
-  > docker run -it <IMAGE_ID> <AWS_ACCESS_KEY_ID> <AWS_SECRET_ACCESS_KEY> <YOUR_STREAM_NAME> <RTSP_URL>
+  > docker run -it <IMAGE_ID> <AWS_ACCESS_KEY_ID> <AWS_SECRET_ACCESS_KEY> <RTSP_URL> <YOUR_STREAM_NAME>
 ```

install-instructions-linux.md

@@ -394,10 +394,6 @@ Ubuntu bulds link against the system versions of the open source component libra
 ```
    to rebuild and re-link the project only.
 
-##### Certificate issues during install-script build
-If you see errors during the build as  _curl failed with 'unable to get local issuer certificate'_ then you can either follow the resolution steps in [81](https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/issues/81)  or you can download the [cacert.pem](https://curl.haxx.se/ca/cacert.pem) into the `kinesis-video-native-build` folder and run
-`./install-script -c`.
-
 ##### Library not found error when running the demo application
 If any error similar to the following shows that the library path is not properly set:
 ```

install-instructions-macos.md

@@ -258,10 +258,6 @@ To resolve this issue, export the LD_LIBRARY_PATH=`<full path to your sdk cpp di
 export LD_LIBRARY_PATH=/opt/awssdk/amazon-kinesis-video-streams-producer-sdk-cpp/kinesis-video-native-build/downloads/local/lib:$LD_LIBRARY_PATH
 ```
 
-##### Certificate issues during install-script build
-If you see errors during the build as  _curl failed with 'unable to get local issuer certificate'_ then you can either follow the resolution steps in [81](https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/issues/81)  or you can download the [cacert.pem](https://curl.haxx.se/ca/cacert.pem) into the `kinesis-video-native-build` folder and run
-`./install-script -c`.
-
 #####  Curl SSL issue - "unable to get local issuer certificate"
 If curl throws *"Peer certificate cannot be authenticated with given CA certificates: SSL certificate problem: unable to get local issuer certificate"* error while sending data to KVS, then the local `curl`
 was not built properly with `--with-ca-bundle` path. So please remove the curl binaries and libraries and rebuilt it again by following below steps.

kinesis-video-gst-demo/kinesis_video_gstreamer_audio_video_sample_app.cpp

@@ -101,7 +101,6 @@ typedef struct _CustomData {
     GMainLoop *main_loop;
     unique_ptr<KinesisVideoProducer> kinesis_video_producer;
     shared_ptr<KinesisVideoStream> kinesis_video_stream;
-    vector<GstElement *> pipelines;
 
     // queue elements to be linked to demuxer's sometimes pad in demux_pad_cb
     GstElement *video_queue, *audio_queue;
@@ -371,15 +370,16 @@ static GstFlowReturn on_new_sample(GstElement *sink, CustomData *data) {
     size_t buffer_size;
     bool delta, dropFrame;
     FRAME_FLAGS kinesis_video_flags;
-    gchar *g_stream_handle_key = gst_element_get_name(sink);
-    int track_id = (string(g_stream_handle_key).back()) - '0';
     uint8_t *data_buffer;
     Frame frame;
     GstFlowReturn ret = GST_FLOW_OK;
     STATUS curr_stream_status = data->stream_status.load();
     GstSegment *segment;
     GstClockTime buf_pts, buf_dts;
     gint dts_sign;
+    gchar *g_stream_handle_key = gst_element_get_name(sink);
+    int track_id = (string(g_stream_handle_key).back()) - '0';
+    g_free(g_stream_handle_key);
 
     if (STATUS_FAILED(curr_stream_status)) {
         // handle network outage in live streaming scenario
@@ -1022,6 +1022,7 @@ int gstreamer_init(int argc, char *argv[], CustomData &data) {
      * Known Issue: In live streaming mode on mac. a null pointer exception from osxaudiosrc will be thrown when the
      * next line is executed.
      */
+    gst_bus_remove_signal_watch(bus);
     gst_element_set_state(pipeline, GST_STATE_NULL);
     gst_object_unref(GST_OBJECT (pipeline));
     g_main_loop_unref(data.main_loop);

kinesis-video-gst-demo/kinesis_video_gstreamer_sample_app.cpp

@@ -1014,6 +1014,7 @@ int gstreamer_init(int argc, char* argv[], CustomData *data) {
     g_main_loop_run(data->main_loop);
 
     /* free resources */
+    gst_bus_remove_signal_watch(bus);
     gst_element_set_state(pipeline, GST_STATE_NULL);
     gst_object_unref(pipeline);
     return 0;

kinesis-video-native-build/install-script

@@ -477,7 +477,7 @@ if [ ! -f $DOWNLOADS/local/bin/yasm ]; then
   echo "yasm-1.3.0.tar.gz not found. Installing"
   if [ ! -f $DOWNLOADS/yasm-1.3.0.tar.gz ]; then
     cd $DOWNLOADS
-    $SYS_CURL -L "https://github.com/yasm/yasm/archive/v1.3.0.tar.gz" -o "yasm-1.3.0.tar.gz"
+    $SYS_CURL -L "http://www.tortall.net/projects/yasm/releases/yasm-1.3.0.tar.gz" -o "yasm-1.3.0.tar.gz"
     cd $DOWNLOADS
   fi
   cd $DOWNLOADS