Skip to content

Commit 316cad3

Browse files
authored
Version user agent string from kvssink (#1033)
1 parent f197610 commit 316cad3

File tree

4 files changed

+15
-6
lines changed

4 files changed

+15
-6
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111

1212
jobs:
1313
mac-os-build-clang:
14-
runs-on: macos-latest
14+
runs-on: macos-13
1515
env:
1616
AWS_KVS_LOG_LEVEL: 2
1717
permissions:
@@ -22,7 +22,7 @@ jobs:
2222
uses: actions/checkout@v3
2323
- name: Install dependencies
2424
run: |
25-
brew install pkg-config openssl cmake gstreamer gst-plugins-base gst-plugins-good gst-plugins-bad gst-plugins-ugly log4cplus gst-libav
25+
brew install pkg-config openssl cmake gstreamer log4cplus
2626
- name: Build repository
2727
run: |
2828
mkdir build && cd build
@@ -42,7 +42,7 @@ jobs:
4242
./tst/producerTest
4343
4444
mac-os-build-gcc:
45-
runs-on: macos-11
45+
runs-on: macos-13
4646
permissions:
4747
id-token: write
4848
contents: read
@@ -55,7 +55,7 @@ jobs:
5555
uses: actions/checkout@v3
5656
- name: Install dependencies
5757
run: |
58-
brew install pkg-config openssl cmake gstreamer gst-plugins-base gst-plugins-good gst-plugins-bad gst-plugins-ugly log4cplus gst-libav
58+
brew install pkg-config openssl cmake gstreamer log4cplus
5959
- name: Build repository
6060
run: |
6161
mkdir build && cd build

CMakeLists.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/CMake;${CMAKE_MODULE_PATH}")
33
include(Utilities)
44
project(KinesisVideoProducerCpp)
55

6+
project(KinesisVideoProducerCpp VERSION 3.3.1)
7+
68
set(CMAKE_CXX_STANDARD 11)
79
include(GNUInstallDirs)
810

@@ -25,6 +27,8 @@ option(MEMORY_SANITIZER "Build with MemorySanitizer" OFF)
2527
option(THREAD_SANITIZER "Build with ThreadSanitizer" OFF)
2628
option(UNDEFINED_BEHAVIOR_SANITIZER "Build with UndefinedBehaviorSanitizer" OFF)
2729

30+
add_definitions(-DVERSION_STRING=\"${PROJECT_VERSION}\")
31+
2832
set(CMAKE_MACOSX_RPATH TRUE)
2933
get_filename_component(ROOT "${CMAKE_CURRENT_SOURCE_DIR}" ABSOLUTE)
3034

src/gstreamer/gstkvssink.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ void kinesis_video_producer_init(GstKvsSink *kvssink)
370370
LOG_INFO("Getting URL from env for " << kvssink->stream_name);
371371
control_plane_uri_str = string(control_plane_uri);
372372
}
373-
373+
LOG_INFO("User agent string: " << kvssink->user_agent);
374374
data->kinesis_video_producer = KinesisVideoProducer::createSync(std::move(device_info_provider),
375375
std::move(client_callback_provider),
376376
std::move(stream_callback_provider),
@@ -711,7 +711,7 @@ gst_kvs_sink_init(GstKvsSink *kvssink) {
711711

712712
// Stream definition
713713
kvssink->stream_name = g_strdup (DEFAULT_STREAM_NAME);
714-
kvssink->user_agent = g_strdup(KVS_CLIENT_USER_AGENT_NAME);
714+
kvssink->user_agent = g_strdup(KVS_CLIENT_USER_AGENT_NAME "/" KVSSINK_USER_AGENT_POSTFIX_VERSION);
715715
kvssink->retention_period_hours = DEFAULT_RETENTION_PERIOD_HOURS;
716716
kvssink->kms_key_id = g_strdup (DEFAULT_KMS_KEY_ID);
717717
kvssink->streaming_type = DEFAULT_STREAMING_TYPE;

src/gstreamer/gstkvssink.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,11 @@ G_BEGIN_DECLS
5757
(G_TYPE_CHECK_CLASS_TYPE((klass),GST_TYPE_KVS_SINK))
5858
#define GST_KVS_SINK_CAST(obj) ((GstKvsSink *)obj)
5959

60+
#ifdef VERSION_STRING
61+
#define KVSSINK_USER_AGENT_POSTFIX_VERSION VERSION_STRING
62+
#else
63+
#define KVSSINK_USER_AGENT_POSTFIX_VERSION "UNKNOWN"
64+
#endif
6065

6166
typedef struct _GstKvsSink GstKvsSink;
6267
typedef struct _GstKvsSinkClass GstKvsSinkClass;

0 commit comments

Comments
 (0)