kvssink soft start/stop support (merging in #1153) (#1257)

* Clean start/stop copy (#1256)

* Starting

* Started clean sample

* more

* Streaming to KVS working

* Intermittent streaming working.

* Add comments, cleanup

* EOS stream message working

* Improvements

* Revert changes to original sample

* more

* more

* Cleanup kvssink

* Cleanup intermittent sample and kvssink

* more

* Remove rtsp related things

* Switch to cv wait for all waits

* Address some PR comments

* Link with kvspicUtils

* kvssink to send eofr upon eos, fix testsrc not stopping issue

* Address review comments

* Don't require stream name arg

* Add sample instructions to README.md

* Fix typos in ReadMe, add language to code blocks

* Install pkgconfiglite

* Address comments

* Fix double space typo

* nit ReadMe change

* Remove no longer used streamingStopped member

* Formatting fix

* Add sample to CI

* Added a duration for CI jobs to use, formatting

* Set sample args in the CI, improve logging

* Add error handling for gst_element_set_state calls

* Fix CI args and logging

* Fix argc check

* Make clockoverlay element optional

* Fix sigint termination

* Fix duration timer shutdown

* Minor fixes

* Fix sigint shutdown

* Disable mkv dump check for intermittent sample

* Disable it on all platforms

Author: stefankiesz

.github/workflows/samples.yml

@@ -58,6 +58,8 @@ jobs:
             args: sample.mp4
           - name: kvssink_gstreamer_sample
             args: sample.mp4
+          - name: kvssink_intermittent_sample # There is no file source option for this sample (will use gst videotestsrc).
+            args: testsrc 120 # <gst-videotestsrc> <sample_duration_seconds>
         runner:
           - id: macos-13
             image: macos-13
@@ -174,7 +176,7 @@ jobs:
           & $exePath demo-stream-producer-cpp-${{ matrix.runner.id }}-ci-${{ matrix.sample.name }} ${{ matrix.sample.args }} ${{ matrix.sample.metadata_args }}
 
       - name: Verify MKV dump exists (Mac & Linux)
-        if: runner.os == 'Linux' || runner.os == 'macOS'
+        if: (runner.os == 'Linux' || runner.os == 'macOS') && matrix.sample.name != 'kvssink_intermittent_sample'
         working-directory: ./build/debug_output
         run: |
           shopt -s nullglob  # Ensure globbing works correctly and avoids errors when no files are found
@@ -193,7 +195,7 @@ jobs:
         shell: bash
 
       - name: Verify MKV dump exists (Windows)
-        if: runner.os == 'Windows'
+        if: runner.os == 'Windows' && matrix.sample.name != 'kvssink_intermittent_sample'
         working-directory: D:\producer\build
         run: |
           $env:Path += ";C:\Program Files\MKVToolNix"
@@ -433,6 +435,8 @@ jobs:
             args: sample.mp4
           - name: kvssink_gstreamer_sample
             args: sample.mp4
+          - name: kvssink_intermittent_sample # There is no file source option for this sample (will use gst videotestsrc).
+            args: testsrc 120 # <gst-videotestsrc> <sample_duration_seconds>
         image:
           - Ubuntu-22.04
           - Ubuntu-24.04
@@ -537,6 +541,7 @@ jobs:
           fi
 
       - name: Verify MKV dump exists (WSL)
+        if: matrix.sample.name != 'kvssink_intermittent_sample'
         run: |
           cd ~/kvs-cpp-repo/build/debug_output
           shopt -s nullglob  # Ensure globbing works correctly and avoids errors when no files are found

CMakeLists.txt

@@ -212,6 +212,9 @@ if(BUILD_GSTREAMER_PLUGIN)
   add_executable(kvssink_gstreamer_sample samples/kvssink_gstreamer_sample.cpp)
   target_link_libraries(kvssink_gstreamer_sample ${GST_APP_LIBRARIES} KinesisVideoProducer)
 
+  add_executable(kvssink_intermittent_sample samples/kvssink_intermittent_sample.cpp )
+  target_link_libraries(kvssink_intermittent_sample ${GST_APP_LIBRARIES} KinesisVideoProducer)
+
   add_executable(kvs_gstreamer_sample samples/kvs_gstreamer_sample.cpp)
   target_link_libraries(kvs_gstreamer_sample ${GST_APP_LIBRARIES} KinesisVideoProducer kvspic)