Release v3.5.0 (#1266)

* Remove Unused Dependency Files

* Rework the ReadMe to be more quick-start friendly (#1173) (#1221)

* Rework the ReadMe to be more quick-start friendly (#1173)

* Start remodeling the ReadMe

* Fix typo, add italics to OS names

* add todo

* Finish up the body

* Update ToC

* Move stuff, fix typos

* Improve title

* Add a line

* Add link for cmake options

* Fix ToC

* Pi->Linux

* Add a comma

* Address feedback

* Add more Windows instructions

* Restructure Debugging section, add more links

* Add some periods

* Add link to Java SDK

* Add link to Producer C SDK in Key Features section

* Convert cmake options list to table

* Add kvssink parameters table, modify credential-path description, cleanup cmake table

* Add stream from file kvssink sample instructions

* Add instructions for how/where to view the footage from the samples in the Quick Start section

* Address comments

* Spelling and grammar

* Remove accidental link

* Downgrade Mac CI GCC version 13->12

* Add AWS Authentication to quickstart section

* megabytes -> mebibytes

* Address comments

* Fix paths

* Format element names

* Remove code formatting from links

* Format fixing

* Update README.md

* Update README.md

* Address comments

* Address comments

* Add link to AWS KVS Raspberry Pi doc

* Add raspberry pi checks to the CI (#1222)

* Add raspberry pi checks to the CI

* Add zerolatency tuning option

* Add comment containing the debian version

* Remove env section

* Adding sample checks & DTS generation for multistream sample (#1229)

* Adding sample checks & invalid dts fix

* Address comments

* Fix Rpi build

* Address comments

* Fix qemu to v7 (#1231)

* kvssink CI enhancements! (#1226)

* Repair unit tests and CI

* Add runtime string checks and additional unit tests

* Add valgrind

* Add reset custom allocators and test timeouts

* Adjust test timeouts

* Add windows debug dump dir check

* Add mac and linux as well

* Address comments

* Address comments

* If no credentials are found, then throw an error instead of failing at file credentials (#1228)

* kvssink - Add Missing Null Checks (#1214)

* Add kvssink null checks

* Update error log

* address comment

* JNI: Fix logging cleanup issue (#1239)

* JNI: Fix logging after free

* Change gstreamer from gitlab to github mirror

* Address comments

* Add retries for rpi build (#1238)

* Add retries for build

* Checking CMake output

* Remove j

* Fix the quotes

* JNI Builds Enhancements & CMake Dependency Enhancements (#1237)

* Build optimizations

* Build PIC in JNI only path

* Make parallel optional

* Adding WSL checks for kvssink and samples (#1232)

* Adding WSL checks for kvssink and samples

* Address comments

* Address comments

* Pr checker (#1242)

* Add PR description lint (#1144)

* Add PR description lint

* windows build fix

* Set CMAKE_OBJECT_PATH_MAX for windows

* Add openssl build

* Allow * characters to be used in the description

---------

Co-authored-by: Divya Sampath Kumar <[email protected]>

* Pin cmake to v3 (#1247)

* Pin CMake version to v3

* Switch to develop branch

* Add GitHub actions setup instructions (#1245)

* Kvssink leak fix and ci (#1250)

* fix memory leak from shared ptr

* Fix kvssink memory leak & add CI

* Move from s3-hosted media and factor out common code

* Upgrade Ubuntu 20->22 and aws-configure-creds to v4

* Add log statement if the shared pointer ref count is not 0

---------

Co-authored-by: Mahesh Ramesh Kumar <[email protected]>

* Adjust windows CI PATH, update chocolatey gstreamer version (#1253)

CI changes for unblocking the sample fix

* fix event metadata tag in  av sample app (#1252)

* Add CI for kvs_gstreamer_audio_video_sample to check for event metadata (#1254)

* Add CI for kvs_gstreamer_audio_video_sample to check for event metadata

* WSL syntax

* Add ReadMe sections from /master (#1255)

* Add bullet points to the PR template (#1259)

* Remove the JNI and adjust the readme (#1258)

* Remove the JNI and adjust the readme

* Options->Option

* Older commits pt 1 (#1241)

* Fix KVSSINK State Transition Deadlock (#1113)

* Change parent class stat change position

* Add failure check

Co-authored-by: Niyati Maheshwari <[email protected]>

* Testing on mac os 13

* Revert ci to mac os 12

* Add comments explaining state transition guidelines

---------

Co-authored-by: Niyati Maheshwari <[email protected]>

* CollectPadsStop to before parent state transition (#1131)

* Add quick-install instructions

* Version check CI (#1167)

* Version check CI

* Version Check CI

* Fix typos in '.cpp' files in 'samples' directory (#1172)

Co-authored-by: BuildTools <[email protected]>

* Potential fix for code scanning alert no. 24: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

---------

Co-authored-by: Stefan Kieszkowski <[email protected]>
Co-authored-by: Niyati Maheshwari <[email protected]>
Co-authored-by: Divya Sampath Kumar <[email protected]>
Co-authored-by: ivanstanislavov <[email protected]>
Co-authored-by: BuildTools <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Bump Producer-C to 1.6.0 (#1261)

* kvssink PutFrame to Return Status Rather than Bool (#1260) Old develop branch PR: #1119

* PutFrame to Return Status Rather than Bool

* add warn on bus, have put frame return actual status

* CI tests account for changed putFrame return value

* More CI putFrame checks update

* Uncomment if block

* Update GST warning type

* Update .gitignore

* Update gstkvssink.cpp

---------

Co-authored-by: Hassan Sahibzada <[email protected]>

* Remove duplicate line in .gitignore

* Create a new function for backwards compat, address comments

---------

Co-authored-by: Hassan Sahibzada <[email protected]>

* kvssink soft start/stop support (merging in #1153) (#1257)

* Clean start/stop copy (#1256)

* Starting

* Started clean sample

* more

* Streaming to KVS working

* Intermittent streaming working.

* Add comments, cleanup

* EOS stream message working

* Improvements

* Revert changes to original sample

* more

* more

* Cleanup kvssink

* Cleanup intermittent sample and kvssink

* more

* Remove rtsp related things

* Switch to cv wait for all waits

* Address some PR comments

* Link with kvspicUtils

* kvssink to send eofr upon eos, fix testsrc not stopping issue

* Address review comments

* Don't require stream name arg

* Add sample instructions to README.md

* Fix typos in ReadMe, add language to code blocks

* Install pkgconfiglite

* Address comments

* Fix double space typo

* nit ReadMe change

* Remove no longer used streamingStopped member

* Formatting fix

* Add sample to CI

* Added a duration for CI jobs to use, formatting

* Set sample args in the CI, improve logging

* Add error handling for gst_element_set_state calls

* Fix CI args and logging

* Fix argc check

* Make clockoverlay element optional

* Fix sigint termination

* Fix duration timer shutdown

* Minor fixes

* Fix sigint shutdown

* Disable mkv dump check for intermittent sample

* Disable it on all platforms

* Bump the user agent to 3.5.0 (#1265)

* Bump the user agent to 3.5.0

* CodeQL suggestions

---------

Co-authored-by: sirknightj <[email protected]>
Co-authored-by: Divya Sampath Kumar <[email protected]>
Co-authored-by: Mahesh Ramesh Kumar <[email protected]>
Co-authored-by: Siva Somasundaram <[email protected]>
Co-authored-by: Niyati Maheshwari <[email protected]>
Co-authored-by: ivanstanislavov <[email protected]>
Co-authored-by: BuildTools <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Hassan Sahibzada <[email protected]>

Author: 10 people

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,6 +1,16 @@
 *Issue #, if available:*
+- N/A
 
-*Description of changes:*
+*What was changed?*
+- 
 
+*Why was it changed?*
+- 
+
+*How was it changed?*
+- 
+
+*What testing was done for the changes?*
+- 
 
 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

.github/configs/no_logs_configuration

@@ -0,0 +1 @@
+log4cplus.rootLogger=OFF

.github/valgrind/glib.supp

@@ -0,0 +1,37 @@
+{
+   glib-dl-memory-leak-ubuntu-22.04
+   Memcheck:Leak
+   match-leak-kinds: definite
+   fun:malloc
+   fun:g_malloc
+   obj:/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7200.4
+   obj:/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7200.4
+   fun:call_init.part.0
+   fun:call_init
+   fun:_dl_init
+   obj:/usr/lib/x86_64-linux-gnu/ld-linux-x86-64.so.2
+   obj:*
+   obj:*
+   obj:*
+   obj:*
+   obj:*
+}
+
+{
+   glib-dl-memory-leak-ubuntu-20.04
+   Memcheck:Leak
+   match-leak-kinds: definite
+   fun:malloc
+   fun:g_malloc
+   obj:/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.6400.6
+   fun:call_init.part.0
+   fun:call_init
+   fun:_dl_init
+   obj:/usr/lib/x86_64-linux-gnu/ld-2.31.so
+   obj:*
+   obj:*
+   obj:*
+   obj:*
+   obj:*
+   obj:*
+}