Make build new option backwards compatible

Author: stefankiesz

CMakeLists.txt

@@ -12,7 +12,7 @@ include(GNUInstallDirs)
 option(BUILD_GSTREAMER_PLUGIN "Build kvssink GStreamer plugin" OFF)
 option(BUILD_JNI "Build C++ wrapper for JNI to expose the functionality to Java/Android" OFF)
 option(BUILD_STATIC "Build with static linkage" OFF)
-option(BUILD_GSTREAMER_PLUGIN_STATIC "If building GStreamer plugin, build it as a static library" ${BUILD_STATIC})
+option(BUILD_FORCE_GSTREAMER_PLUGIN_SHARED "If building with static linkage, build the kvssink GStreamer plugin as a shared library" OFF)
 option(ADD_MUCLIBC "Add -muclibc c flag" OFF)
 option(BUILD_DEPENDENCIES "Whether or not to build depending libraries from source" ON)
 option(BUILD_OPENSSL_PLATFORM "If buildng OpenSSL what is the target platform" OFF)
@@ -215,7 +215,7 @@ if(BUILD_GSTREAMER_PLUGIN)
   include_directories(${GST_APP_INCLUDE_DIRS})
   link_directories(${GST_APP_LIBRARY_DIRS})
 
-  if(BUILD_GSTREAMER_PLUGIN_STATIC)
+  if(BUILD_STATIC AND (NOT BUILD_FORCE_GSTREAMER_PLUGIN_SHARED))
     add_library(gstkvssink STATIC ${GST_PLUGIN_SOURCE_FILES})
   else()
     add_library(gstkvssink MODULE ${GST_PLUGIN_SOURCE_FILES})

README.md

@@ -84,7 +84,7 @@ You can pass the following options to `cmake ..`.
 
 * `-DBUILD_GSTREAMER_PLUGIN` -- Build kvssink GStreamer plugin. Default is OFF.
 * `-DBUILD_STATIC` -- Build as static libraries. Default is OFF.
-* `-DBUILD_GSTREAMER_PLUGIN_STATIC` -- If building GStreamer plugin, build it as a static library. Default is BUILD_STATIC.
+* `-BUILD_FORCE_GSTREAMER_PLUGIN_SHARED` -- If building with static linkage, build the kvssink GStreamer plugin as a shared library. Default is OFF.
 * `-DBUILD_JNI` -- Build C++ wrapper for JNI to expose the functionality to Java/Android
 * `-DBUILD_DEPENDENCIES` -- Build depending libraries from source
 * `-DBUILD_TEST=TRUE` -- Build unit/integration tests, may be useful for confirm support for your device. `./tst/producerTest`