Add valgrind

Author: sirknightj

.github/workflows/kvssink.yml

@@ -40,7 +40,7 @@ jobs:
             gstreamer1.0-tools \
             libcurl4-openssl-dev libgstreamer1.0-dev \
             libgstreamer-plugins-base1.0-dev liblog4cplus-dev \
-            libssl-dev pkg-config
+            libssl-dev pkg-config valgrind
 
       - name: Setup build directory
         run: |
@@ -66,3 +66,18 @@ jobs:
         run: |
           export GST_PLUGIN_PATH=`pwd`
           GST_DEBUG=4 ./tst/gstkvsplugintest 
+
+      - name: Run the unit tests with valgrind
+        working-directory: ./build
+        run: |
+          export GST_PLUGIN_PATH=`pwd`
+          valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes \
+            --verbose --log-file=valgrind-out.txt ./tst/gstkvsplugintest
+
+          if grep -q "All heap blocks were freed -- no leaks are possible" valgrind-out.txt; then
+            echo "No memory leaks detected"
+          else
+            echo "Memory leaks detected. Review the valgrind output:"
+            cat valgrind-out.txt
+            exit 1
+          fi

tst/gstreamer/gstkvstest.cpp

@@ -212,12 +212,14 @@ GST_START_TEST(check_properties_are_passed_correctly)
 
         g_object_get(G_OBJECT (pElement), "stream-name", &str_val, NULL);
         assert_equals_string(TEST_STREAM_NAME.c_str(), str_val);
+        g_free(str_val);
         g_object_get(G_OBJECT (pElement), "retention-period", &uint_val, NULL);
         assert_equals_uint64(TEST_RETENTION_PERIOD, uint_val);
         g_object_get(G_OBJECT (pElement), "streaming-type", &uint_val, NULL);
         assert_equals_uint64(TEST_STREAMING_TYPE, uint_val);
         g_object_get(G_OBJECT (pElement), "content-type", &str_val, NULL);
         assert_equals_string(TEST_CONTENT_TYPE.c_str(), str_val);
+        g_free(str_val);
         g_object_get(G_OBJECT (pElement), "max-latency", &uint_val, NULL);
         assert_equals_uint64(TEST_MAX_LATENCY, uint_val);
         g_object_get(G_OBJECT (pElement), "fragment-duration", &uint_val, NULL);
@@ -248,16 +250,21 @@ GST_START_TEST(check_properties_are_passed_correctly)
         assert_equals_uint64(TEST_CONNECTION_STALENESS, uint_val);
         g_object_get(G_OBJECT (pElement), "codec-id", &str_val, NULL);
         assert_equals_string(TEST_CODEC_ID.c_str(), str_val);
+        g_free(str_val);
         g_object_get(G_OBJECT (pElement), "track-name", &str_val, NULL);
         assert_equals_string(TEST_TRACK_NAME.c_str(), str_val);
+        g_free(str_val);
         g_object_get(G_OBJECT (pElement), "access-key", &str_val, NULL);
         assert_equals_string(TEST_ACCESS_KEY.c_str(), str_val);
+        g_free(str_val);
         g_object_get(G_OBJECT (pElement), "secret-key", &str_val, NULL);
         assert_equals_string(TEST_SECRET_KEY.c_str(), str_val);
+        g_free(str_val);
         g_object_get(G_OBJECT (pElement), "rotation-period", &uint_val, NULL);
         assert_equals_uint64(TEST_ROTATION_PERIOD, uint_val);
         g_object_get(G_OBJECT (pElement), "log-config", &str_val, NULL);
         assert_equals_string(TEST_LOG_CONFIG.c_str(), str_val);
+        g_free(str_val);
 
         cleanup_kinesisvideoproducersink(pElement);