fix producer cpp set correct default for intermittent producer scenar… (#654)

* fix producer cpp set correct default for intermittent producer scenario and docs

* better logical ordering of ip scenario

* formatting

* be more explicit about not tearing down SDK pipeline

Author: hassanctech

CMake/Dependencies/libkvscproducer-CMakeLists.txt

@@ -7,7 +7,7 @@ include(ExternalProject)
 # clone repo only
 ExternalProject_Add(libkvscproducer-download
 	GIT_REPOSITORY    https://github.com/awslabs/amazon-kinesis-video-streams-producer-c.git
-	GIT_TAG           d1095356712729d0489e56d1d0e27f5ce0a29fad
+	GIT_TAG           dcde7e188a74daffb62986a7d172128d3c6f4b48
 	SOURCE_DIR        "${CMAKE_CURRENT_BINARY_DIR}/kvscproducer-src"
 	BINARY_DIR        "${CMAKE_CURRENT_BINARY_DIR}/kvscproducer-build"
 	CONFIGURE_COMMAND ""

docs/intermittent_producer.md

@@ -0,0 +1,21 @@
+## What is intermittent streaming?
+Intermittent streaming is when you want to send and stop video at will without having to teardown and setup the SDK pipeline again.  For example consider a doorbell camera which only wants to record motion events.  The application might want to start producing frames as soon as it detects motion and then stop at some point when there is no longer motion and then not stream again until it detects motion. 
+
+## Intermittent Producer Handling
+### Before v3.1.0
+The KVS back-end times out after 30s of not receiving any frames.  If the SDK received frames after 30+ seconds of no frames then it would error.  We introduced a complex way for client applications to be able to make an API call which would signal to the backend that we're done recording and to close out the session.  However this does not work in cases where the stream application doesn't know that it's "done" streaming and it also doesn't know in advance whether or not it will need to stream again within the next 30s. 
+
+
+### Since v3.1.0
+By default we have automatic handling for intermittent streaming.  This means client applications don't need to do anything other than just put frames when they have them and simply do nothing when there are no frames to send, the SDK will take care of making sure the back-end is notified when there are gaps in the stream and even if it's hours between streaming the client application doesn't need to do anything simply continue putting frames as you would normally.  
+This comes at a cost of using 1 extra thread to manage the timer used by the SDK to automatically signal to the KVS back-end that a fragment can be closed out.  If on a prior release of the SDK you were manually setting fields like `stream_info_.streamCaps.frameOrderingMode` you no longer should do that.  
+
+If for some reason you would like to opt-out of this functionality (which is enabled by default) then in the method `KinesisVideoProducer::create` right after we create `device_info` you can set the following:
+
+```
+device_info.clientInfo.automaticStreamingFlags = AUTOMATIC_STREAMING_ALWAYS_CONTINUOUS
+```
+
+
+
+

src/StreamDefinition.cpp

@@ -108,7 +108,7 @@ void StreamDefinition::addTrack(const uint64_t track_id,
                                 MKV_TRACK_INFO_TYPE track_type,
                                 const uint8_t* codecPrivateData,
                                 uint32_t codecPrivateDataSize) {
-    stream_info_.streamCaps.frameOrderingMode = FRAME_ORDERING_MODE_MULTI_TRACK_AV_COMPARE_PTS_ONE_MS_COMPENSATE;
+    stream_info_.streamCaps.frameOrderingMode = FRAME_ORDERING_MODE_MULTI_TRACK_AV_COMPARE_PTS_ONE_MS_COMPENSATE_EOFR;
     track_info_.push_back(StreamTrackInfo{track_id,
                                           track_name,
                                           codec_id,