Move check out of switch (#660)

* provide option for non-standard GStreamer src/mux plugins which have GST_CLOCK_TIME_NONE segment start

* the disable_buffer_clipping check needs to be out of the switch otherwise it's only ever set if property is explicitly set, default would be ignored

* fix

* don't use TRUE/FALSE for comparison for gboolean

Author: hassanctech

src/gstreamer/gstkvssink.cpp

@@ -249,6 +249,12 @@ void kinesis_video_producer_init(GstKvsSink *kvssink)
     string region_str;
     bool credential_is_static = true;
 
+    // This needs to happen after we've read in ALL of the properties
+    if (!kvssink->disable_buffer_clipping) {
+        gst_collect_pads_set_clip_function(kvssink->collect,
+                                           GST_DEBUG_FUNCPTR(gst_collect_pads_clip_running_time), kvssink);
+    }
+
     if (0 == strcmp(kvssink->access_key, DEFAULT_ACCESS_KEY)) { // if no static credential is available in plugin property.
         if (nullptr == (access_key = getenv(ACCESS_KEY_ENV_VAR))
             || nullptr == (secret_key = getenv(SECRET_KEY_ENV_VAR))) { // if no static credential is available in env var.
@@ -777,14 +783,9 @@ gst_kvs_sink_set_property(GObject *object, guint prop_id,
         case PROP_FILE_START_TIME:
             kvssink->file_start_time = g_value_get_uint64 (value);
             break;
-        case PROP_DISABLE_BUFFER_CLIPPING: {
+        case PROP_DISABLE_BUFFER_CLIPPING:
             kvssink->disable_buffer_clipping = g_value_get_boolean(value);
-            if (kvssink->disable_buffer_clipping == FALSE) {
-                gst_collect_pads_set_clip_function(kvssink->collect,
-                                                   GST_DEBUG_FUNCPTR(gst_collect_pads_clip_running_time), kvssink);
-            }
             break;
-        }
         default:
             G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
             break;
@@ -980,7 +981,7 @@ gst_kvs_sink_handle_sink_event (GstCollectPads *pads,
             LOG_INFO("received kvs-add-metadata event");
             if (NULL == gst_structure_get_string(structure, KVS_ADD_METADATA_NAME) ||
                 NULL == gst_structure_get_string(structure, KVS_ADD_METADATA_VALUE) ||
-                FALSE == gst_structure_get_boolean(structure, KVS_ADD_METADATA_PERSISTENT, &persistent)) {
+                !gst_structure_get_boolean(structure, KVS_ADD_METADATA_PERSISTENT, &persistent)) {
 
                 LOG_WARN("Event structure contains invalid field: " << std::string(gst_structure_to_string (structure)));
                 goto CleanUp;
@@ -991,7 +992,7 @@ gst_kvs_sink_handle_sink_event (GstCollectPads *pads,
             is_persist = persistent;
 
             bool result = data->kinesis_video_stream->putFragmentMetadata(metadata_name, metadata_value, is_persist);
-            if (false == result) {
+            if (!result) {
                 LOG_WARN("Failed to putFragmentMetadata. name: " << metadata_name << ", value: " << metadata_value << ", persistent: " << is_persist);
             }
             gst_event_unref (event);