Skip to content

Conversation

@mit-aws
Copy link
Contributor

@mit-aws mit-aws commented Feb 3, 2025

Issue:

  • Current code sample is not working as expected.
  • The SNS topic is not able to publish a message without valid policy which gives permission to SNS topic to send message to subscribed SQS queue.

Description of changes:

Code Sample

  • Attach the policy to SQS queue to receive messages from subscribed SNS topic.
  • Update the SQS client's recieve_message attributes to receive consistent output.
  • Delete the received_messages from SQS queue
  • Add the case to publish a message through PlatformEndpoint Resource.

Required changes for the migration from s3 resource interface to client

  • Updates the description of s3_client attribute of sns_extended_client
  • Updates the example to set custom s3 config for s3_client attribute

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jagdev-aws
jagdev-aws previously approved these changes Feb 4, 2025
Copy link

@jagdev-aws jagdev-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mit-aws mit-aws requested a review from jalukaharsh February 5, 2025 18:14
@mit-aws mit-aws changed the title Update the code sample in Readme Update Readme for newer library version Feb 10, 2025
Copy link

@jagdev-aws jagdev-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mit-aws mit-aws merged commit dcf21b4 into main Feb 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants