Add integration test #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagdev-aws
reviewed
Feb 14, 2025
jagdev-aws
left a comment
jagdev-aws
left a comment
There was a problem hiding this comment.
How would these integration tests be executed, can we add an execution for integration tests as part of the release workflow, https://github.com/awslabs/amazon-sqs-python-extended-client-lib/blob/main/.github/workflows/release.yml#L62
jagdev-aws
reviewed
Feb 14, 2025
jagdev-aws
reviewed
Feb 14, 2025
jagdev-aws
reviewed
Feb 14, 2025
jagdev-aws
left a comment
jagdev-aws
left a comment
There was a problem hiding this comment.
Also let's bump the version as part of this PR, let's publish changes to PyPi
Contributor
Author
Added integration tests to release workflow and Unit tests to Pull Request workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description of changes:
test_send_publish_small_msg_through_s3:test_send_publish_small_msg_not_through_s3test_send_publish_large_msg_which_passes_threshold_through_s3test_send_publish_msg_with_custom_s3_keyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.