add bsd

Author: xiazhvera

include/aws/common/platform.h

@@ -31,6 +31,10 @@
 #    define AWS_OS_LINUX
 #endif
 
+#if defined(__FreeBSD__) || defined(__NetBSD__)
+#    define AWS_OS_BSD
+#endif
+
 #if defined(__ANDROID__)
 #    define AWS_OS_ANDROID
 #endif

include/aws/common/system_info.h

@@ -21,7 +21,8 @@ AWS_PUSH_SANE_WARNING_LEVEL
  * - AWS_PLATFORM_OS_TVOS    → "tvOS"       (Apple TV devices)
  * - AWS_PLATFORM_OS_WATCHOS → "watchOS"    (Apple Watch devices)
  * - AWS_PLATFORM_OS_ANDROID → "Android"    (Android)
- * - AWS_PLATFORM_OS_UNIX    → "Unix"       (Linux, BSD, other Unix-like)
+ * - AWS_PLATFORM_OS_BSD     → "BSD"        (FreeBSD, NetBSD)
+ * - AWS_PLATFORM_OS_UNIX    → "Unix"       (Linux, other Unix-like)
  */
 enum aws_platform_os {
     AWS_PLATFORM_OS_WINDOWS,
@@ -30,6 +31,7 @@ enum aws_platform_os {
     AWS_PLATFORM_OS_TVOS,
     AWS_PLATFORM_OS_WATCHOS,
     AWS_PLATFORM_OS_ANDROID,
+    AWS_PLATFORM_OS_BSD,
     AWS_PLATFORM_OS_UNIX,
 };
 

source/posix/system_info.c

@@ -468,7 +468,6 @@ void aws_backtrace_log(int log_level) {
 enum aws_platform_os aws_get_platform_build_os(void) {
 #if defined(AWS_OS_MACOS)
     return AWS_PLATFORM_OS_MAC;
-// Other Apple platforms will be reported as iOS
 #elif defined(AWS_OS_IOS)
     return AWS_PLATFORM_OS_IOS;
 #elif defined(AWS_OS_TVOS)
@@ -477,6 +476,8 @@ enum aws_platform_os aws_get_platform_build_os(void) {
     return AWS_PLATFORM_OS_WATCHOS;
 #elif defined(AWS_OS_ANDROID)
     return AWS_PLATFORM_OS_ANDROID;
+#elif defined(AWS_OS_BSD)
+    return AWS_PLATFORM_OS_BSD;
 #else
     return AWS_PLATFORM_OS_UNIX;
 #endif

source/system_info.c

@@ -84,9 +84,12 @@ size_t aws_system_environment_get_cpu_group_count(const struct aws_system_enviro
  * follow common industry conventions:
  * - "Windows" - Microsoft Windows family
  * - "macOS" - Apple macOS
- * - "iOS" - Apple iOS (or other unknown Apple platform)
+ * - "iOS" - Apple iOS
+ * - "tvOS" - Apple tvOS
+ * - "watchOS" - Apple watchOS
  * - "Android" - Google Android mobile OS
- * - "Unix" - Unix-like systems (Linux, BSD, etc.)
+ * - "BSD" - BSD family (FreeBSD, NetBSD, etc.)
+ * - "Unix" - Unix-like systems (Linux, unix-like etc.)
  * - "Unknown" - Fallback for unrecognized platforms
  */
 
@@ -118,9 +121,13 @@ struct aws_byte_cursor aws_get_platform_build_os_string(void) {
             break;
         case AWS_PLATFORM_OS_WATCHOS:
             os_str = aws_byte_cursor_from_c_str("watchOS");
+            break;
         case AWS_PLATFORM_OS_ANDROID:
             os_str = aws_byte_cursor_from_c_str("Android");
             break;
+        case AWS_PLATFORM_OS_BSD:
+            os_str = aws_byte_cursor_from_c_str("BSD");
+            break;
         case AWS_PLATFORM_OS_UNIX:
             os_str = aws_byte_cursor_from_c_str("Unix");
             break;

tests/system_info_tests.c

@@ -128,6 +128,8 @@ static int s_test_platform_build_os_fn(struct aws_allocator *allocator, void *ct
     ASSERT_INT_EQUALS(build_os, AWS_PLATFORM_OS_ANDROID);
 #elif defined(_WIN32)
     ASSERT_INT_EQUALS(build_os, AWS_PLATFORM_OS_WINDOWS);
+#elif defined(AWS_OS_BSD)
+    ASSERT_INT_EQUALS(build_os, AWS_PLATFORM_OS_BSD);
 #else
     ASSERT_INT_EQUALS(build_os, AWS_PLATFORM_OS_UNIX);
 #endif
@@ -165,6 +167,8 @@ static int s_test_platform_build_os_string_fn(struct aws_allocator *allocator, v
     expected_os = aws_byte_cursor_from_c_str("Android-");
 #elif defined(AWS_OS_WINDOWS)
     expected_os = aws_byte_cursor_from_c_str("Windows-");
+#elif defined(AWS_OS_BSD)
+    expected_os = aws_byte_cursor_from_c_str("BSD-");
 #else
     expected_os = aws_byte_cursor_from_c_str("Unix-");
 #endif
@@ -177,7 +181,7 @@ static int s_test_platform_build_os_string_fn(struct aws_allocator *allocator, v
 #if defined(AWS_ARCH_INTEL)
     ASSERT_TRUE(aws_byte_cursor_eq_c_str(&os_string, "intel"));
 #elif defined(AWS_ARCH_INTEL_64)
-    ASSERT_TRUE(aws_byte_cursor_eq_c_str(&os_string, "intel_64"));
+    ASSERT_TRUE(aws_byte_cursor_eq_c_str(&os_string, "intel64"));
 #elif defined(AWS_ARCH_ARM64)
     ASSERT_TRUE(aws_byte_cursor_eq_c_str(&os_string, "arm64"));
 #elif defined(AWS_ARCH_ARM32)