Remove lambda attributes (#282)

Author: coltonweaver

Cargo.lock

@@ -1,6 +1,5 @@
 [workspace]
 members = [
     "lambda",
-    "lambda-attributes",
     "lambda-http"
 ]

Cargo.toml

@@ -19,7 +19,6 @@ maintenance = { status = "actively-developed" }
 base64 = "0.12"
 http = "0.2"
 lambda = { path = "../lambda", version = "0.1" }
-lambda-attributes = { path = "../lambda-attributes", version = "0.1" }
 serde = "^1"
 serde_derive = "^1"
 serde_json = "^1"

lambda-attributes/Cargo.toml

@@ -1,12 +1,23 @@
 use lambda_http::{
-    lambda::{lambda, Context},
-    IntoResponse, Request,
+    handler,
+    lambda::{self, Context},
+    IntoResponse, Request, RequestExt, Response,
 };
 
 type Error = Box<dyn std::error::Error + Send + Sync + 'static>;
 
-#[lambda(http)]
 #[tokio::main]
-async fn main(_: Request, _: Context) -> Result<impl IntoResponse, Error> {
-    Ok("👋 world")
+async fn main() -> Result<(), Error> {
+    lambda::run(handler(func)).await?;
+    Ok(())
+}
+
+async fn func(event: Request, _: Context) -> Result<impl IntoResponse, Error> {
+    Ok(match event.query_string_parameters().get("first_name") {
+        Some(first_name) => format!("Hello, {}!", first_name).into_response(),
+        _ => Response::builder()
+            .status(400)
+            .body("Empty first name".into())
+            .expect("failed to render response"),
+    })
 }

lambda-attributes/src/lib.rs

@@ -11,33 +11,10 @@
 //!
 //! ## Hello World
 //!
-//! `lambda_http` handlers adapt to the standard `lambda::Handler` interface using the [`handler`](fn.handler.html) function.
-//!
-//! The simplest case of an http handler is a function of an `http::Request` to a type that can be lifted into an `http::Response`.
-//! You can learn more about these types [here](trait.IntoResponse.html).
-//!
-//! Adding an `#[lambda(http)]` attribute to a `#[tokio::run]`-decorated `main` function will setup and run the Lambda function.
-//!
-//! Note: this comes at the expense of any onetime initialization your lambda task might find value in.
-//! The full body of your `main` function will be executed on **every** invocation of your lambda task.
-//!
-//! ```rust,no_run
-//! use lambda_http::{lambda::{lambda, Context}, Request, IntoResponse};
-//!
-//! type Error = Box<dyn std::error::Error + Send + Sync + 'static>;
-//!
-//! #[lambda(http)]
-//! #[tokio::main]
-//! async fn main(_: Request, _: Context) -> Result<impl IntoResponse, Error> {
-//!     Ok("👋 world!")
-//! }
-//! ```
-//!
-//! ## Hello World, Without Macros
-//!
-//! For cases where your lambda might benfit from one time function initializiation might
-//! prefer a plain `main` function and invoke `lambda::run` explicitly in combination with the [`handler`](fn.handler.html) function.
-//! Depending on the runtime cost of your dependency bootstrapping, this can reduce the overall latency of your functions execution path.
+//! The following example is how you would structure your Lambda such that you have a `main` function where you explicitly invoke
+//! `lambda::run` in combination with the [`handler`](fn.handler.html) function. This pattern allows you to utilize global initialization
+//! of tools such as loggers, to use on warm invokes to the same Lambda function after the first request, helping to reduce the latency of
+//! your function's execution path.
 //!
 //! ```rust,no_run
 //! use lambda_http::{handler, lambda};
@@ -51,7 +28,6 @@
 //!     lambda::run(handler(|request, context| async { Ok("👋 world!") })).await?;
 //!     Ok(())
 //! }
-//!
 //! ```
 //!
 //! ## Leveraging trigger provided data
@@ -92,7 +68,6 @@ extern crate maplit;
 pub use http::{self, Response};
 use lambda::Handler as LambdaHandler;
 pub use lambda::{self, Context};
-pub use lambda_attributes::lambda;
 
 mod body;
 pub mod ext;

lambda-http/Cargo.toml

@@ -7,9 +7,8 @@ edition = "2018"
 license = "Apache-2.0"
 
 [features]
-default = ["simulated", "derive"]
+default = ["simulated"]
 simulated = []
-derive = ["lambda-attributes"]
 
 [dependencies]
 tokio = { version = "1.0", features = ["macros", "io-util", "sync", "rt-multi-thread"] }
@@ -18,7 +17,6 @@ serde = { version = "1", features = ["derive"] }
 serde_json = "1.0.39"
 bytes = "1.0"
 http = "0.2"
-lambda-attributes = { path = "../lambda-attributes", version = "0.1.0", optional = true}
 async-stream = "0.3"
 futures = "0.3"
 tracing = "0.1.13"