-
Notifications
You must be signed in to change notification settings - Fork 13
Add API changelog check workflow #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Looks good over all - added some suggestions from Zizmor, which we should add to this repo to run over all GH actions to run by default in the long run. |
|
Thanks @SamRemis! I just pushed a new commit with the fixes added from running I opened this test PR to make sure this still runs properly. Example: API model change with NO changelog entry:
Workflow: https://github.com/jonathan343/aws-sdk-python/actions/runs/20889335156/job/60017993475 Example: API model change with a changelog entry: Workflow: https://github.com/jonathan343/aws-sdk-python/actions/runs/20889424472/job/60018217980 |
SamRemis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks, Jonathan :)


Summary
Add a GitHub Actions workflow to ensure changelog entries are added when manually updating AWS models. When a PR modifies files in
codegen/aws-models/, this workflow verifies that a corresponding changelog entry exists inclients/aws-sdk-<service>/.changes/next-release/.Workflow Behavior
modifies codegen/aws-models/*.jsonskip-changeloglabel presentValidation Requirements
A valid changelog entry must:
"type": "api-change"and a"description"fieldTest plan
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.