Commit 1b5a5c2
[smithy-rs] remove redundant span attributes and improve log output format (#4075)
## Description
smithy-lang/smithy-rs#4052 aligned our spans
closer to SRA but the output format resulted in `rpc.service` and
`rpc.method` on both the new generated operation span and the internal
orchestrator `invoke` span. This resulted in pretty long and clutter log
output. This PR cleans up the log output a bit to have only the top
level operation span include these attributes. This also fixes a subtle
bug where presigned requests wouldn't contain the same top level
operation span instrumentation because presigned requests make use of
`<Operation>::orchestrate_with_stop_point` and not
`<Operation>::orchestrate`. For IMDS and other "manually constructed"
operations, I've moved the `invoke` span instrumentation into
`Operation::invoke` to ensure we still capture that information in the
logs for those use cases.
Example output format:
```
2025-03-28T14:44:02.471068Z DEBUG S3.ListBuckets{rpc.service="S3" rpc.method="ListBuckets" sdk_invocation_id=4073472 rpc.system="aws-api"}:try_op: aws_smithy_runtime::cli
ent::orchestrator: beginning attempt #1
```
## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] For changes to the smithy-rs codegen or runtime crates, I have
created a changelog entry Markdown file in the `.changelog` directory,
specifying "client," "server," or both in the `applies_to` key.
----
_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._1 parent a250cbe commit 1b5a5c2
File tree
17,162 files changed
+180949
-174621
lines changed- examples
- cross_service
- photo_asset_management
- rest_ses
- examples
- custom-root-certificates
- dynamodb
- s3
- testing
- tls
- test-utils
- sdk
- accessanalyzer
- src/operation
- account
- src/operation
- acmpca
- src/operation
- acm
- src/operation
- amplifybackend
- src/operation
- amplifyuibuilder
- src/operation
- amplify
- src/operation
- amp
- src/operation
- apigatewaymanagement
- src/operation
- apigatewayv2
- src/operation
- apigateway
- src/operation
- appconfigdata
- src/operation
- appconfig
- src/operation
- appfabric
- src/operation
- appflow
- src/operation
- appintegrations
- src/operation
- applicationautoscaling
- src/operation
- applicationcostprofiler
- src/operation
- applicationdiscovery
- src/operation
- applicationinsights
- src/operation
- applicationsignals
- src/operation
- appmesh
- src/operation
- apprunner
- src/operation
- appstream
- src/operation
- appsync
- src/operation
- apptest
- src/operation
- arczonalshift
- src/operation
- artifact
- src/operation
- athena
- src/operation
- auditmanager
- src/operation
- autoscalingplans
- src/operation
- autoscaling
- src/operation
- aws-config
- aws-runtime
- aws-smithy-runtime
- src/client
- orchestrator
- aws-types
- b2bi
- src/operation
- backupgateway
- src/operation
- backupsearch
- src/operation
- backup
- src/operation
- batch
- src/operation
- bcmdataexports
- src/operation
- bcmpricingcalculator
- src/operation
- bedrockagentruntime
- src/operation
- bedrockagent
- src/operation
- bedrockdataautomationruntime
- src/operation
- bedrockdataautomation
- src/operation
- bedrockruntime
- src/operation
- bedrock
- src/operation
- billingconductor
- src/operation
- billing
- src/operation
- braket
- src/operation
- budgets
- src/operation
- chatbot
- src/operation
- chimesdkidentity
- src/operation
- chimesdkmediapipelines
- src/operation
- chimesdkmeetings
- src/operation
- chimesdkmessaging
- src/operation
- chimesdkvoice
- src/operation
- chime
- src/operation
- cleanroomsml
- src/operation
- cleanrooms
- src/operation
- cloud9
- src/operation
- cloudcontrol
- src/operation
- clouddirectory
- src/operation
- cloudformation
- src/operation
- cloudfrontkeyvaluestore
- src/operation
- cloudfront
- src/operation
- cloudhsmv2
- src/operation
- cloudhsm
- src/operation
- cloudsearchdomain
- src/operation
- cloudsearch
- src/operation
- cloudtraildata
- src/operation
- cloudtrail
- src/operation
- cloudwatchevents
- src/operation
- cloudwatchlogs
- src/operation
- cloudwatch
- src/operation
- codeartifact
- src/operation
- codebuild
- src/operation
- codecatalyst
- src/operation
- codecommit
- src/operation
- codeconnections
- src/operation
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
17,162 files changed
+180949
-174621
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | 30 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | 31 | | |
42 | 32 | | |
43 | 33 | | |
| |||
60 | 50 | | |
61 | 51 | | |
62 | 52 | | |
| 53 | + | |
63 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
0 commit comments