Added set_payload_override to UploadPartInputBuilder, PutObject, and GetObjectInputBuilder

[jiashiwen]

Describe the feature

Added set_payload_override to UploadPartInputBuilder, PutObject, and GetObjectInputBuilder to prevent frequent calls to sigv4 when using aws_sigv4::http_request::SignableBody to change object transfers, causing high CPU usage.

Use Case

  let payload_override = aws_sigv4::http_request::SignableBody::UnsignedPayload;
  let upload_part_res = client
        .upload_part()
        .set_payload_override(payload_override)
        .bucket(bucket)
        .key(key)
        .upload_id(upload_id)
        .body(stream)
        .part_number(p.part_num)
        .send()
        .await?;

Proposed Solution

impl UploadPartInputBuilder {
pub fn set_payload_override(mut self, payload_override: ::aws_sigv4::http_request::SignableBody) -> Self {
self.inner.signing_options.payload_override = payload_override;;
self
}
}

Other Information

#1085

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

A note for the community

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue, please leave a comment

[rcoh]

agreed we definitely need a way to support this. I think we'll need an RFC / design doc to investigate the best way to support this generally. I think this is probably possible with an interceptor today but definitely not the best user experience.

[jiashiwen]

I have implemented this by modifying sdk/s3/src/operation/upload_part/builders.rs to add a new function send_with_plugins.
The modification code is as follows:

impl UploadPartFluentBuilder {
    pub async fn send(
        self,
    ) -> ::std::result::Result<
        crate::operation::upload_part::UploadPartOutput,
        ::aws_smithy_runtime_api::client::result::SdkError<
            crate::operation::upload_part::UploadPartError,
            ::aws_smithy_runtime_api::client::orchestrator::HttpResponse,
        >,
    > {
        let input = self
            .inner
            .build()
            .map_err(::aws_smithy_runtime_api::client::result::SdkError::construction_failure)?;
        let runtime_plugins = crate::operation::upload_part::UploadPart::operation_runtime_plugins(
            // self.handle.runtime_plugins.clone(),
            self.handle.runtime_plugins.clone().with_client_plugin(
                crate::presigning_interceptors::SigV4PresigningRuntimePlugin::new(
                    crate::presigning::PresigningConfig::expires_in(
                        std::time::Duration::from_secs(3000),
                    )
                    .unwrap(),
                    ::aws_sigv4::http_request::SignableBody::UnsignedPayload,
                ),
            ),
            &self.handle.conf,
            self.config_override,
        );
        crate::operation::upload_part::UploadPart::orchestrate(&runtime_plugins, input).await
    }

    pub async fn send_with_plugins(
        self,
        presigning_config: PresigningConfig,
    ) -> ::std::result::Result<
        crate::operation::upload_part::UploadPartOutput,
        result::SdkError<
            crate::operation::upload_part::UploadPartError,
            ::aws_smithy_runtime_api::client::orchestrator::HttpResponse,
        >,
    > {
        let input = self
            .inner
            .build()
            .map_err(result::SdkError::construction_failure)?;

        let plugin = crate::presigning_interceptors::SigV4PresigningRuntimePlugin::new(
            presigning_config,
            ::aws_sigv4::http_request::SignableBody::UnsignedPayload,
        );
        let runtime_plugins = crate::operation::upload_part::UploadPart::operation_runtime_plugins(
            // self.handle.runtime_plugins.clone(),
            self.handle
                .runtime_plugins
                .clone()
                .with_client_plugin(plugin),
            &self.handle.conf,
            self.config_override,
        );
        crate::operation::upload_part::UploadPart::orchestrate(&runtime_plugins, input).await
    }

}

Use case

let presigning = PresigningConfig::expires_in(std::time::Duration::from_secs(3000))?;
        let upload_part_res = self
            .client
            .upload_part()
            .upload_id(upload_id)
            .part_number(part_number)
            .bucket(bucket)
            .key(key)
            .body(stream)
            .send_with_plugins(presigning)
            .await?;

Is this a good user experience?
I can submit pr if officially allowed

[aajtodd]

You can now disable payload signing for select S3 operations as of the 12-18-2024 release.

[github-actions]

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.