Skip to content

Commit c8ca305

Browse files
authored
fix: removes warning (#330)
1 parent 62f20cc commit c8ca305

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

AWSClientRuntime/Sources/Middlewares/RetrierMiddleware.swift

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,16 @@ public struct RetrierMiddleware<Output: HttpResponseBinding,
2222
input: SdkHttpRequestBuilder,
2323
next: H) -> Result<OperationOutput<Output>, SdkError<OutputError>>
2424
where H: Handler,
25-
Self.MInput == H.Input,
26-
Self.MOutput == H.Output,
27-
Self.Context == H.Context,
28-
Self.MError == H.MiddlewareError {
25+
Self.MInput == H.Input,
26+
Self.MOutput == H.Output,
27+
Self.Context == H.Context,
28+
Self.MError == H.MiddlewareError {
2929

30+
guard let region = context.getRegion(), !region.isEmpty else {
31+
return .failure(.client(ClientError.unknownError(("Region is unable to be resolved"))))
32+
}
3033
do {
31-
let partitionId = "\(context.getServiceName()) - \(context.getRegion())"
34+
let partitionId = "\(context.getServiceName()) - \(region))"
3235
let token = try retrier.acquireToken(partitionId: partitionId)
3336
return try tryRequest(token: token, partitionId: partitionId, context: context, input: input, next: next)
3437

@@ -44,10 +47,10 @@ public struct RetrierMiddleware<Output: HttpResponseBinding,
4447
input: SdkHttpRequestBuilder,
4548
next: H) throws -> Result<OperationOutput<Output>, SdkError<OutputError>>
4649
where H: Handler,
47-
Self.MInput == H.Input,
48-
Self.MOutput == H.Output,
49-
Self.Context == H.Context,
50-
Self.MError == H.MiddlewareError {
50+
Self.MInput == H.Input,
51+
Self.MOutput == H.Output,
52+
Self.Context == H.Context,
53+
Self.MError == H.MiddlewareError {
5154
defer { retrier.releaseToken(token: token)}
5255

5356
let serviceResponse = next.handle(context: context, input: input)

codegen/smithy-aws-swift-codegen/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/AWSHttpProtocolCustomizations.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ abstract class AWSHttpProtocolCustomizations : DefaultHttpProtocolCustomizations
3939
// FIXME handle indentation properly or do swift formatting after the fact
4040
writer.write(" .withCredentialsProvider(value: config.credentialsProvider)")
4141
writer.write(" .withRegion(value: config.region)")
42-
writer.write(" .withHost(value: \"$endpointPrefix.\\(config.region).amazonaws.com\")")
4342
if (AWSSigningMiddleware.hasSigV4AuthScheme(ctx.model, ctx.service, op)) {
4443
val signingName = AWSSigningMiddleware.signingServiceName(serviceShape)
4544
writer.write(" .withSigningName(value: \$S)", signingName)

0 commit comments

Comments
 (0)