feat: Add codegen build plugin to AWS services #2053
Draft
+33
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jbelkins
commented
Nov 10, 2025
| static var SmithyTimestamps: Self { .product(name: "SmithyTimestamps", package: "smithy-swift") } | ||
| static var SmithyWaitersAPI: Self { .product(name: "SmithyWaitersAPI", package: "smithy-swift") } | ||
| static var SmithyXML: Self { .product(name: "SmithyXML", package: "smithy-swift") } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Everything below is just a copy of the changes in Package.base.txt above
jbelkins
commented
Nov 10, 2025
| rm -rf Sources/Services/* | ||
| rm -rf Tests/Services/* | ||
| rm -rf SmokeTests/* | ||
| rm -rf Sources/Core/AWSIdentity/InternalClients/* |
Contributor
Author
There was a problem hiding this comment.
Delete internal clients so they are regenerated completely during codegen
jbelkins
commented
Nov 10, 2025
| // Smithy plugins | ||
| static var SmithyCodeGenerator: Self { .plugin(name: "SmithyCodeGenerator", package: "smithy-swift") } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Above, a convenience var with the code generator plugin is defined.
Below, the plugin is inserted into all of our service clients (public and internal.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Applies the Swift-native codegen plugin defined in smithy-lang/smithy-swift#993 to AWS service clients, including the internal ones.
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.