Skip to content

Commit 3ec214d

Browse files
Use besteffort minValuePolicy in Helm and add minValues support for training and titan pools (#574)
1 parent 2de652a commit 3ec214d

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

tests/assets/karpenter/ai-ml-training-large.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,15 @@ spec:
4040
values:
4141
- linux
4242
- key: karpenter.k8s.aws/instance-size
43+
minValues: 4
4344
operator: In
4445
values:
4546
- large
4647
- xlarge
4748
- 2xlarge
4849
- 4xlarge
4950
- key: karpenter.k8s.aws/instance-family
51+
minValues: 33
5052
operator: In
5153
values:
5254
- c5

tests/assets/karpenter/titan-pool.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,15 @@ spec:
3434
values:
3535
- on-demand
3636
- key: karpenter.k8s.aws/instance-size
37+
minValues: 4
3738
operator: In
3839
values:
3940
- large
4041
- xlarge
4142
- 2xlarge
4243
- 4xlarge
4344
- key: karpenter.k8s.aws/instance-family
45+
minValues: 33
4446
operator: In
4547
values:
4648
- c5

tests/tekton-resources/tasks/setup/karpenter/helm-karpenter-install.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ spec:
9292
--set "tolerations[0].value=karpenter" \
9393
--set "tolerations[0].operator=Equal" \
9494
--set "dnsPolicy=Default" \
95+
--set "settings.minValuesPolicy=BestEffort" \
9596
--set-string "controller.env[0].name=AWS_ENDPOINT_URL_EKS" \
9697
--set-string "controller.env[0].value=$(params.endpoint)" \
9798
--set-string "controller.env[1].name=KUBE_CLIENT_QPS" \

0 commit comments

Comments
 (0)