This repository was archived by the owner on Nov 20, 2025. It is now read-only.
This repository was archived by the owner on Nov 20, 2025. It is now read-only.
model-server-worker fails without "optional" arguments #909
Description
Small bug in model-server-worker, which fails if the optional arguments handler, model-path, or model-name are not provided.
docstring:
Usage: model-server-worker [-h] --sock-type {unix,tcp} [--sock-name SOCK_NAME]
[--host HOST] [--port PORT] [--handler HANDLER]
[--model-path MODEL_PATH] [--model-name MODEL_NAME]
--preload-model PRELOAD_MODEL --tmp-dir TMP_DIR
When debugging custom service code, I usually invoke the model-server-worker manually like:
python model_service_worker.py --sock-type unix --sock-name /tmp/.mms.sock.9000 --preload-model false --tmp-dir /tmp
However, this fails under 1.1.0 due to the recent addition of the following argument encoding code, which fails when any of these arguments are None type:
multi-model-server/mms/model_service_worker.py
Lines 235 to 237 in 70e8f1f