Skip to content

Commit 2123dfe

Browse files
committed
Fix path to DCP tests and limit their run to linux and macOS ARM64 only (#255)
1 parent a59cd54 commit 2123dfe

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

s3torchconnectorclient/pyproject.toml

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,6 @@ test-command = [
5959
"pytest {package}/../s3torchconnector/tst/unit/lightning",
6060
"CI_STORAGE_CLASS='' CI_REGION=${S3_REGION} CI_BUCKET=${S3_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL=${S3_CUSTOM_ENDPOINT_URL} pytest {package}/../s3torchconnector/tst/e2e/test_e2e_s3_lightning_checkpoint.py",
6161
"AWS_DEFAULT_REGION=${S3_EXPRESS_REGION} CI_STORAGE_CLASS=EXPRESS_ONEZONE CI_REGION=${S3_EXPRESS_REGION} CI_BUCKET=${S3_EXPRESS_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL='' pytest {package}/../s3torchconnector/tst/e2e/test_e2e_s3_lightning_checkpoint.py",
62-
"python -m pip install -e '{package}/../s3torchconnector[dcp-test]'",
63-
"pytest {package}/../s3torchconnector/tst/unit/dcp",
64-
"CI_STORAGE_CLASS='' CI_REGION=${S3_REGION} CI_BUCKET=${S3_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL=${S3_CUSTOM_ENDPOINT_URL} pytest {package}/../s3torchconnector/tst/e2e/dcp/test_e2e_s3_file_system.py",
65-
"AWS_DEFAULT_REGION=${S3_EXPRESS_REGION} CI_STORAGE_CLASS=EXPRESS_ONEZONE CI_REGION=${S3_EXPRESS_REGION} CI_BUCKET=${S3_EXPRESS_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL='' pytest {package}/../s3torchconnector/tst/e2e/dcp/test_e2e_s3_file_system.py",
6662
]
6763
environment-pass = [
6864
"AWS_ACCESS_KEY_ID",
@@ -95,3 +91,17 @@ before-all = [
9591
"yum install -y llvm-toolset-7.0-clang"
9692
]
9793
environment = { PATH="/opt/rh/llvm-toolset-7.0/root/usr/bin:/opt/rh/devtoolset-10/root/usr/bin:$HOME/.cargo/bin:$PATH", LD_LIBRARY_PATH="/opt/rh/llvm-toolset-7.0/root/usr/lib64:/opt/rh/devtoolset-10/root/usr/lib64:/opt/rh/devtoolset-10/root/usr/lib", CC="/opt/rh/devtoolset-10/root/usr/bin/gcc", CXX="/opt/rh/devtoolset-10/root/usr/bin/g++" }
94+
95+
96+
[[tool.cibuildwheel.overrides]]
97+
# We want to run DCP's tests only on Linux and macOS ARM64 platforms because
98+
# DCP requires PyTorch >= 2.3, and PyTorch has stopped supporting the Intel platform for macOS
99+
# since version 2.3. See https://dev-discuss.pytorch.org/t/pytorch-macos-x86-builds-deprecation-starting-january-2024/1690
100+
select = "{*linux*,*macosx_arm64}"
101+
inherit.test-command = "append"
102+
test-command = [
103+
"python -m pip install -e '{package}/../s3torchconnector[dcp-test]'",
104+
"pytest {package}/../s3torchconnector/tst/unit/dcp",
105+
"CI_STORAGE_CLASS='' CI_REGION=${S3_REGION} CI_BUCKET=${S3_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL=${S3_CUSTOM_ENDPOINT_URL} pytest {package}/../s3torchconnector/tst/e2e/dcp/test_e2e_s3_file_system.py",
106+
"AWS_DEFAULT_REGION=${S3_EXPRESS_REGION} CI_STORAGE_CLASS=EXPRESS_ONEZONE CI_REGION=${S3_EXPRESS_REGION} CI_BUCKET=${S3_EXPRESS_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL='' pytest {package}/../s3torchconnector/tst/e2e/dcp/test_e2e_s3_file_system.py",
107+
]

0 commit comments

Comments
 (0)