You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Move around `DEVELOPMENT.md` file into the repository root folder.
Delete `doc/CODE_OF_CONDUCT.md` and `doc/CONTRIBUTING.md`, both
duplicates (already present in the repository root folder). Reuse
`doc/CONTRIBUTING.md` content, more up to date. Update file
references wherever required, and use relative ones.
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,5 +1,5 @@
1
1
## Description
2
-
<!-- Thank you for submitting a pull request! Find more information in our development guide at [DEVELOPMENT](https://github.com/awslabs/s3-connector-for-pytorch/blob/main/doc/DEVELOPMENT.md) -->
2
+
<!-- Thank you for submitting a pull request! Find more information in our development guide at [DEVELOPMENT](DEVELOPMENT.md) -->
3
3
<!-- Provide an overview of the PR for maintainers and reviewers. -->
4
4
<!-- Please ensure your commit messages follow these [guidelines](https://chris.beams.io/posts/git-commit/). -->
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+1-2Lines changed: 1 addition & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -32,14 +32,13 @@ To send us a pull request, please:
32
32
1. Fork the repository.
33
33
2. Modify the source; please focus on the specific change you are contributing. If you also reformat all the code, it will be hard for us to focus on your change.
34
34
3. Ensure local tests pass.
35
-
4. Commit to your fork using clear commit messages.
35
+
4. Commit to your fork using clear commit messages. When writing a Git commit message, follow these [guidelines](https://chris.beams.io/posts/git-commit/).
36
36
5. Send us a pull request, answering any default questions in the pull request interface.
37
37
6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.
38
38
39
39
GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and
40
40
[creating a pull request](https://help.github.com/articles/creating-a-pull-request/).
41
41
42
-
43
42
## Finding contributions to work on
44
43
Looking at the existing issues is a great way to find something to contribute on. As our projects, by default, use the default GitHub issue labels (enhancement/bug/duplicate/help wanted/invalid/question/wontfix), looking at any 'help wanted' issues is a great place to start.
0 commit comments