Skip to content

Commit 7f00661

Browse files
IsaevIlyaIlya Isaev
andauthored
Update worfkflows for optional tests under dcp prefix and increase timeout (#270)
Co-authored-by: Ilya Isaev <[email protected]>
1 parent 93b0bcb commit 7f00661

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

.github/workflows/python-checks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
- name: s3torchconnectorclient unit tests
5353
run: pytest s3torchconnectorclient/python/tst/unit --hypothesis-profile ci --hypothesis-show-statistics -c ./
5454
- name: s3torchconnector unit tests
55-
run: pytest s3torchconnector/tst/unit --ignore s3torchconnector/tst/unit/lightning --hypothesis-profile ci --hypothesis-show-statistics -c ./
55+
run: pytest s3torchconnector/tst/unit --ignore-glob '*/**/lightning' --ignore-glob '*/**/dcp' --hypothesis-profile ci --hypothesis-show-statistics -c ./
5656
- name: s3torchbenchmarking unit tests
5757
run: pytest s3torchbenchmarking/tst --hypothesis-profile ci --hypothesis-show-statistics -c ./
5858

.github/workflows/python-integration.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ jobs:
5252
with:
5353
role-to-assume: ${{ vars.ACTIONS_IAM_ROLE }}
5454
aws-region: ${{ vars.S3_REGION }}
55+
# extend role time out to 2 hours
56+
role-duration-seconds: 7200
5557

5658
- name: Set up stable Rust
5759
uses: dtolnay/rust-toolchain@stable
@@ -86,7 +88,7 @@ jobs:
8688
CI_REGION=${{ matrix.test-run.region }} \
8789
CI_BUCKET=${{ matrix.test-run.bucket }} \
8890
CI_STORAGE_CLASS=${{ matrix.test-run.storage-class }} \
89-
pytest s3torchconnector/tst/e2e --ignore s3torchconnector/tst/e2e/test_e2e_s3_lightning_checkpoint.py -n auto
91+
pytest s3torchconnector/tst/e2e --ignore-glob '*/**/test_e2e_s3_lightning_checkpoint.py' --ignore-glob '*/**/dcp' -n auto
9092
9193
- name: Install Lightning dependency
9294
run: |

.github/workflows/wheels.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ jobs:
5858
with:
5959
role-to-assume: ${{ vars.ACTIONS_IAM_ROLE }}
6060
aws-region: ${{ vars.S3_REGION }}
61+
# extend role time out to 2 hours
62+
role-duration-seconds: 7200
6163

6264
- uses: actions/download-artifact@v4
6365
with:

s3torchconnectorclient/pyproject.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ test-requires = ["./s3torchconnector[e2e]"]
5050
test-extras = "test"
5151
test-command = [
5252
"pytest {package}/python/tst/unit",
53-
"pytest {package}/../s3torchconnector/tst/unit --ignore {package}/../s3torchconnector/tst/unit/lightning",
53+
"pytest {package}/../s3torchconnector/tst/unit --ignore {package}/../s3torchconnector/tst/unit/lightning --ignore {package}/../s3torchconnector/tst/unit/dcp",
5454
"CI_STORAGE_CLASS='' CI_REGION=${S3_REGION} CI_BUCKET=${S3_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL=${S3_CUSTOM_ENDPOINT_URL} pytest {package}/python/tst/integration",
55-
"CI_STORAGE_CLASS='' CI_REGION=${S3_REGION} CI_BUCKET=${S3_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL=${S3_CUSTOM_ENDPOINT_URL} pytest {package}/../s3torchconnector/tst/e2e --ignore {package}/../s3torchconnector/tst/e2e/test_e2e_s3_lightning_checkpoint.py",
55+
"CI_STORAGE_CLASS='' CI_REGION=${S3_REGION} CI_BUCKET=${S3_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL=${S3_CUSTOM_ENDPOINT_URL} pytest {package}/../s3torchconnector/tst/e2e --ignore {package}/../s3torchconnector/tst/e2e/test_e2e_s3_lightning_checkpoint.py --ignore {package}/../s3torchconnector/tst/e2e/dcp",
5656
"CI_STORAGE_CLASS=EXPRESS_ONEZONE CI_REGION=${S3_EXPRESS_REGION} CI_BUCKET=${S3_EXPRESS_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL='' pytest {package}/python/tst/integration",
57-
"CI_STORAGE_CLASS=EXPRESS_ONEZONE CI_REGION=${S3_EXPRESS_REGION} CI_BUCKET=${S3_EXPRESS_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL='' pytest {package}/../s3torchconnector/tst/e2e --ignore {package}/../s3torchconnector/tst/e2e/test_e2e_s3_lightning_checkpoint.py",
57+
"CI_STORAGE_CLASS=EXPRESS_ONEZONE CI_REGION=${S3_EXPRESS_REGION} CI_BUCKET=${S3_EXPRESS_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL='' pytest {package}/../s3torchconnector/tst/e2e --ignore {package}/../s3torchconnector/tst/e2e/test_e2e_s3_lightning_checkpoint.py --ignore {package}/../s3torchconnector/tst/e2e/dcp",
5858
"python -m pip install -e '{package}/../s3torchconnector[lightning-tests]'",
5959
"pytest {package}/../s3torchconnector/tst/unit/lightning",
6060
"CI_STORAGE_CLASS='' CI_REGION=${S3_REGION} CI_BUCKET=${S3_BUCKET} CI_PREFIX=${S3_PREFIX} CI_CUSTOM_ENDPOINT_URL=${S3_CUSTOM_ENDPOINT_URL} pytest {package}/../s3torchconnector/tst/e2e/test_e2e_s3_lightning_checkpoint.py",

0 commit comments

Comments
 (0)