Skip to content

Commit a9cecd3

Browse files
authored
Update dependencies audit check and add wheels build check (#148)
* Update dependencies audit check and add wheels build check * Update checkout action
1 parent fe0740f commit a9cecd3

File tree

2 files changed

+35
-12
lines changed

2 files changed

+35
-12
lines changed

.github/workflows/python-checks.yml

Lines changed: 35 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ jobs:
2121
steps:
2222
- name: Checkout code
2323
uses: actions/checkout@v4
24-
with:
25-
submodules: true
2624

2725
- name: Set up stable Rust
2826
uses: actions-rs/toolchain@v1
@@ -66,8 +64,6 @@ jobs:
6664
steps:
6765
- name: Checkout code
6866
uses: actions/checkout@v4
69-
with:
70-
submodules: true
7167

7268
- name: Set up stable Rust
7369
uses: actions-rs/toolchain@v1
@@ -109,8 +105,6 @@ jobs:
109105
steps:
110106
- name: Checkout code
111107
uses: actions/checkout@v4
112-
with:
113-
submodules: true
114108

115109
- name: Install Python dependencies
116110
run: |
@@ -130,11 +124,41 @@ jobs:
130124
with:
131125
inputs: "s3torchconnectorclient"
132126

133-
# TODO: This fails during release as we publish the binaries together
134-
# - name: Audit s3torchconnector dependencies
135-
# uses: pypa/[email protected]
136-
# with:
137-
# inputs: "s3torchconnector"
127+
- name: Install local s3torchconnectorclient
128+
run: |
129+
python -m pip install -e "s3torchconnectorclient"
130+
- name: Audit s3torchconnector dependencies
131+
uses: pypa/[email protected]
132+
with:
133+
inputs: "s3torchconnector"
138134

139135
- name: Security vulnerabilities check s3torchconnector
140136
run: safety check -r s3torchconnector/requirements.txt
137+
138+
wheels:
139+
name: Wheels build checks
140+
runs-on: ubuntu-22.04
141+
142+
steps:
143+
- name: Checkout code
144+
uses: actions/checkout@v4
145+
with:
146+
submodules: true
147+
148+
- name: Install Python dependencies
149+
run: |
150+
python -m pip install --upgrade pip
151+
152+
- name: Check s3torchconnectorclient wheels build
153+
run: |
154+
rm -rf /tmp/check_wheels/tmp_client_wheel
155+
mkdir -p /tmp/check_wheels/tmp_client_wheel
156+
python -m pip wheel "s3torchconnectorclient" \
157+
--wheel-dir=/tmp/check_wheels/tmp_client_wheel --no-deps --no-cache-dir
158+
159+
- name: Check s3torchconnector wheels build
160+
run: |
161+
rm -rf /tmp/check_wheels/tmp_connector_wheel
162+
mkdir -p /tmp/check_wheels/tmp_connector_wheel
163+
python -m pip wheel "s3torchconnector" \
164+
--wheel-dir=/tmp/check_wheels/tmp_connector_wheel --no-deps --no-cache-dir

.github/workflows/python-integration.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ jobs:
4444
uses: actions/checkout@v4
4545
with:
4646
ref: ${{ inputs.ref }}
47-
submodules: true
4847
persist-credentials: false
4948

5049
- name: Configure AWS credentials

0 commit comments

Comments
 (0)