Skip to content

Commit ea101e9

Browse files
authored
Keep usage of manylinux_2014 for wider suport of glibc (#343)
Continue building wheels with manylinux_2014 to ensure broader compatibility with systems using older glibc versions, maximizing distribution support This reverts commit 7e3793e.
1 parent 0e12e8f commit ea101e9

File tree

3 files changed

+16
-23
lines changed

3 files changed

+16
-23
lines changed

.github/workflows/wheels.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,8 @@ jobs:
9797
# Run cibuildwheel manually, as the current runner uses setup-python
9898
# https://github.com/pypa/cibuildwheel/issues/1623
9999
- run: >
100+
CIBW_MANYLINUX_X86_64_IMAGE=manylinux2014
101+
CIBW_MANYLINUX_AARCH64_IMAGE=manylinux2014
100102
python -m pipx run
101103
cibuildwheel
102104
"s3torchconnectorclient"

run_cibuildwheel_on_ec2.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ export S3_EXPRESS_REGION=${EXPRESS_REGION_NAME}
3131
export S3_EXPRESS_BUCKET=${EXPRESS_BUCKET_NAME}
3232
export S3_CUSTOM_ENDPOINT_URL=${S3_CUSTOM_ENDPOINT_URL}
3333

34-
cibuildwheel --output-dir wheelhouse --platform linux s3torchconnectorclient
34+
CIBW_MANYLINUX_X86_64_IMAGE=manylinux2014 CIBW_MANYLINUX_AARCH64_IMAGE=manylinux2014 cibuildwheel --output-dir wheelhouse --platform linux s3torchconnectorclient

s3torchconnectorclient/pyproject.toml

Lines changed: 13 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -77,29 +77,20 @@ skip = "*musllinux* *i686"
7777

7878
[tool.cibuildwheel.linux]
7979
before-all = [
80-
"yum -y update",
81-
"yum -y install openssl3 openssl3-devel",
82-
"yum install -y gcc-toolset-10-gcc",
83-
"yum install -y gcc-toolset-10-gcc-c++",
84-
"yum install -y clang clang-devel llvm-toolset",
85-
86-
"curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stable -y",
87-
"bash -c 'platform=$(uname -p); if [ \"$platform\" == \"aarch64\" ]; then sed -i \"s|centos/7|altarch/7|g\" /etc/yum.repos.d/*.repo; fi'",
88-
89-
"yum install -y fuse",
90-
"yum install -y fuse-devel",
91-
"yum install -y make",
92-
"yum install -y git",
93-
"yum install -y pkgconfig",
94-
"yum install -y tar",
95-
"yum install -y wget"
80+
"curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stable -y",
81+
"bash -c 'platform=$(uname -p); if [ \"$platform\" == \"aarch64\" ]; then sed -i \"s|centos/7|altarch/7|g\" /etc/yum.repos.d/*.repo; fi'",
82+
"yum install -y fuse",
83+
"yum install -y fuse-devel",
84+
"yum install -y make",
85+
"yum install -y git",
86+
"yum install -y pkgconfig",
87+
"yum install -y tar",
88+
"yum install -y wget",
89+
"yum install -y devtoolset-10-gcc",
90+
"yum install -y devtoolset-10-gcc-c++",
91+
"yum install -y llvm-toolset-7.0-clang"
9692
]
97-
98-
[tool.cibuildwheel.linux.environment]
99-
PATH = "/usr/lib64/ccache:/usr/lib64/llvm:/opt/rh/gcc-toolset-10/root/usr/bin:$HOME/.cargo/bin:$PATH"
100-
LD_LIBRARY_PATH = "/usr/lib64/llvm:/opt/rh/gcc-toolset-10/root/usr/lib64:/opt/rh/gcc-toolset-10/root/usr/lib:$LD_LIBRARY_PATH"
101-
CC = "/opt/rh/gcc-toolset-10/root/usr/bin/gcc"
102-
CXX = "/opt/rh/gcc-toolset-10/root/usr/bin/g++"
93+
environment = { PATH="/opt/rh/llvm-toolset-7.0/root/usr/bin:/opt/rh/devtoolset-10/root/usr/bin:$HOME/.cargo/bin:$PATH", LD_LIBRARY_PATH="/opt/rh/llvm-toolset-7.0/root/usr/lib64:/opt/rh/devtoolset-10/root/usr/lib64:/opt/rh/devtoolset-10/root/usr/lib", CC="/opt/rh/devtoolset-10/root/usr/bin/gcc", CXX="/opt/rh/devtoolset-10/root/usr/bin/g++" }
10394

10495
[tool.cibuildwheel.macos]
10596
environment = { MACOSX_DEPLOYMENT_TARGET = "10.12" }

0 commit comments

Comments
 (0)