Skip to content

Commit 40e5f50

Browse files
Exclude ImdsAutoConfiguration from unrelated tests to speed up startup time (#1394)
1 parent 5e03cdf commit 40e5f50

File tree

5 files changed

+17
-10
lines changed

5 files changed

+17
-10
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: Java CI with Maven
22

33
on:
44
push:
5-
branches: [ main, 2.3.x, 2.4.x, 3.0.x, 3.1.x, 3.2.x ]
5+
branches: [ main, 2.3.x, 2.4.x, 3.0.x, 3.1.x, 3.2.x, 3.3.x ]
66
pull_request:
7-
branches: [ main, 2.3.x, 2.4.x, 3.0.x, 3.1.x, 3.2.x ]
7+
branches: [ main, 2.3.x, 2.4.x, 3.0.x, 3.1.x, 3.2.x, 3.3.x ]
88

99
permissions:
1010
contents: read

spring-cloud-aws-autoconfigure/src/test/java/io/awspring/cloud/autoconfigure/config/parameterstore/ParameterStoreConfigDataLoaderIntegrationTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
import io.awspring.cloud.autoconfigure.AwsSyncClientCustomizer;
2626
import io.awspring.cloud.autoconfigure.ConfiguredAwsClient;
27+
import io.awspring.cloud.autoconfigure.imds.ImdsAutoConfiguration;
2728
import java.io.IOException;
2829
import java.time.Duration;
2930
import org.junit.jupiter.api.AfterEach;
@@ -440,7 +441,7 @@ private static void overwriteParameter(LocalStackContainer localstack, String pa
440441
}
441442

442443
@SpringBootConfiguration
443-
@EnableAutoConfiguration
444+
@EnableAutoConfiguration(exclude = ImdsAutoConfiguration.class)
444445
static class App {
445446

446447
}

spring-cloud-aws-autoconfigure/src/test/java/io/awspring/cloud/autoconfigure/config/s3/S3ConfigDataLoaderIntegrationTests.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,14 @@
1616
package io.awspring.cloud.autoconfigure.config.s3;
1717

1818
import static org.assertj.core.api.Assertions.assertThat;
19-
import static org.mockito.Mockito.*;
19+
import static org.mockito.Mockito.spy;
20+
import static org.mockito.Mockito.when;
2021
import static org.testcontainers.containers.localstack.LocalStackContainer.Service.S3;
2122
import static org.testcontainers.shaded.org.awaitility.Awaitility.await;
2223

2324
import io.awspring.cloud.autoconfigure.AwsSyncClientCustomizer;
2425
import io.awspring.cloud.autoconfigure.ConfiguredAwsClient;
26+
import io.awspring.cloud.autoconfigure.imds.ImdsAutoConfiguration;
2527
import io.awspring.cloud.autoconfigure.s3.S3ClientCustomizer;
2628
import java.io.IOException;
2729
import java.time.Duration;
@@ -31,9 +33,9 @@
3133
import org.springframework.boot.BootstrapRegistry;
3234
import org.springframework.boot.BootstrapRegistryInitializer;
3335
import org.springframework.boot.SpringApplication;
36+
import org.springframework.boot.SpringBootConfiguration;
3437
import org.springframework.boot.WebApplicationType;
3538
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
36-
import org.springframework.boot.autoconfigure.SpringBootApplication;
3739
import org.springframework.context.ConfigurableApplicationContext;
3840
import org.testcontainers.containers.localstack.LocalStackContainer;
3941
import org.testcontainers.junit.jupiter.Container;
@@ -229,8 +231,8 @@ public void initialize(BootstrapRegistry registry) {
229231
}
230232
}
231233

232-
@SpringBootApplication
233-
@EnableAutoConfiguration
234+
@SpringBootConfiguration
235+
@EnableAutoConfiguration(exclude = ImdsAutoConfiguration.class)
234236
static class App {
235237

236238
}

spring-cloud-aws-autoconfigure/src/test/java/io/awspring/cloud/autoconfigure/config/secretsmanager/SecretsManagerConfigDataLoaderIntegrationTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
import io.awspring.cloud.autoconfigure.AwsSyncClientCustomizer;
2626
import io.awspring.cloud.autoconfigure.ConfiguredAwsClient;
27+
import io.awspring.cloud.autoconfigure.imds.ImdsAutoConfiguration;
2728
import java.io.File;
2829
import java.io.IOException;
2930
import java.nio.charset.Charset;
@@ -491,7 +492,7 @@ private static void putSecretValue(LocalStackContainer localstack, String secret
491492
}
492493

493494
@SpringBootConfiguration
494-
@EnableAutoConfiguration
495+
@EnableAutoConfiguration(exclude = ImdsAutoConfiguration.class)
495496
static class App {
496497
}
497498

spring-cloud-aws-autoconfigure/src/test/java/io/awspring/cloud/autoconfigure/metrics/CloudWatchExportAutoConfigurationIntegrationTests.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,16 @@
1818
import static org.assertj.core.api.Assertions.assertThat;
1919
import static org.testcontainers.shaded.org.awaitility.Awaitility.await;
2020

21+
import io.awspring.cloud.autoconfigure.imds.ImdsAutoConfiguration;
2122
import io.micrometer.core.instrument.Counter;
2223
import io.micrometer.core.instrument.MeterRegistry;
2324
import java.time.Duration;
2425
import java.time.Instant;
2526
import org.junit.jupiter.api.Test;
2627
import org.springframework.boot.SpringApplication;
28+
import org.springframework.boot.SpringBootConfiguration;
2729
import org.springframework.boot.WebApplicationType;
28-
import org.springframework.boot.autoconfigure.SpringBootApplication;
30+
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
2931
import org.springframework.boot.test.autoconfigure.actuate.observability.AutoConfigureObservability;
3032
import org.springframework.context.ConfigurableApplicationContext;
3133
import org.springframework.test.context.DynamicPropertyRegistry;
@@ -98,7 +100,8 @@ void testCounter() {
98100
}
99101
}
100102

101-
@SpringBootApplication
103+
@SpringBootConfiguration
104+
@EnableAutoConfiguration(exclude = ImdsAutoConfiguration.class)
102105
@AutoConfigureObservability(tracing = false)
103106
static class Application {
104107

0 commit comments

Comments
 (0)